Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIBULKED-497: "Are you sure" preview displays outdated values after User changed selection on bulk edit form and clicked "Confirm changes" #619

Merged
merged 4 commits into from
Oct 24, 2024

Conversation

UladzislauKutarkin
Copy link
Contributor

https://folio-org.atlassian.net/browse/UIBULKED-497

Here we updated the logic or preview rendering in-app modal, to prevent errors and outdated values in the MLC

The new logic in shown on 5k records, since that problem only reproduced on large data set

Screen.Recording.2024-10-23.at.14.10.54.mov

the result
Screenshot 2024-10-23 at 14 24 16

…ser changed selection on bulk edit form and clicked "Confirm changes"
@UladzislauKutarkin UladzislauKutarkin requested review from vashjs and a team October 23, 2024 10:29
Copy link

github-actions bot commented Oct 23, 2024

Jest Unit Test Statistics

    1 files  ±0    43 suites  ±0   3m 3s ⏱️ -6s
285 tests ±0  285 ✔️ ±0  0 💤 ±0  0 ±0 
292 runs  ±0  292 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 494dd63. ± Comparison against base commit b5d3cf4.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Oct 23, 2024

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit 494dd63. ± Comparison against base commit b5d3cf4.

♻️ This comment has been updated with latest results.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
72.7% Coverage on New Code (required ≥ 80%)
4.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@UladzislauKutarkin UladzislauKutarkin merged commit 23d9bc2 into master Oct 24, 2024
5 of 6 checks passed
@UladzislauKutarkin UladzislauKutarkin deleted the UIBULKED-497 branch October 24, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants