Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIBULKED-404: Render preview after query executed #475

Merged
merged 9 commits into from
Feb 14, 2024

Conversation

UladzislauKutarkin
Copy link
Contributor

https://folio-org.atlassian.net/browse/UIBULKED-404
Here we added runQueryDataSource functionality with rendering preview. Also separated functionality for rendering Preview for different criteria

Screen.Recording.2024-02-12.at.15.13.26.mov

@UladzislauKutarkin UladzislauKutarkin requested review from vashjs and a team February 12, 2024 11:17
Copy link

github-actions bot commented Feb 12, 2024

Jest Unit Test Statistics

    1 files  ±0    33 suites  ±0   2m 57s ⏱️ +2s
196 tests +1  195 ✔️ +1  1 💤 ±0  0 ±0 
200 runs  +2  199 ✔️ +2  1 💤 ±0  0 ±0 

Results for commit 21bbcd4. ± Comparison against base commit 4620e76.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 12, 2024

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit 21bbcd4. ± Comparison against base commit 4620e76.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@NikitaSedyx NikitaSedyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

permissions are not updated

@NikitaSedyx
Copy link
Contributor

query is not human readable

@UladzislauKutarkin
Copy link
Contributor Author

query is not human readable

I know about that, we need to discuss it with the backend guys, because I don't know how we can convert it on the UI side. In ui-list backend side returns human readable query

@UladzislauKutarkin
Copy link
Contributor Author

UladzislauKutarkin commented Feb 12, 2024

permissions are not updated

I'll check, but permission was adapted for the query early. But let me check it. Backend permission will be updated.

package.json Outdated Show resolved Hide resolved
@NikitaSedyx NikitaSedyx requested a review from a team February 14, 2024 07:47
@NikitaSedyx NikitaSedyx requested a review from a team February 14, 2024 09:29
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
75.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@UladzislauKutarkin UladzislauKutarkin merged commit 72a2a3e into master Feb 14, 2024
5 of 6 checks passed
@UladzislauKutarkin UladzislauKutarkin deleted the UIBULKED-404 branch February 14, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants