Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UIBULKED-403 enable query-related call only on Query tab #468

Merged
merged 4 commits into from
Feb 5, 2024
Merged

UIBULKED-403 enable query-related call only on Query tab #468

merged 4 commits into from
Feb 5, 2024

Conversation

vashjs
Copy link
Contributor

@vashjs vashjs commented Feb 2, 2024 •
edited
Loading

In scope of #461 PR, some parts were missed. Fixed:

  • Query execution only on required tab (errors in console)
  • Was added correct reset of state when tab was changed

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 2, 2024 •
edited
Loading

Jest Unit Test Statistics

    1 files  ±0    33 suites  ±0   3m 0s ⏱️ +3s
195 tests ±0  194 ✔️ ±0  1 💤 ±0  0 ❌ ±0 
198 runs  ±0  197 ✔️ ±0  1 💤 ±0  0 ❌ ±0 

Results for commit bc83b90. ± Comparison against base commit ae1867f.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 2, 2024 •
edited
Loading

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit bc83b90. ± Comparison against base commit ae1867f.

♻️ This comment has been updated with latest results.

@vashjs vashjs force-pushed the UIBULKED-403-fix-query branch from 0587f58 to 729dcc9 Compare February 2, 2024 17:16
@vashjs vashjs force-pushed the UIBULKED-403-fix-query branch from b45a3d9 to e636500 Compare February 4, 2024 23:48
@vashjs vashjs requested review from SergeYvas and a team February 5, 2024 00:00
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
54.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@OleksandrHladchenko1 OleksandrHladchenko1 requested a review from a team February 5, 2024 13:32
@vashjs vashjs merged commit 5898d75 into master Feb 5, 2024
6 checks passed
@vashjs vashjs deleted the UIBULKED-403-fix-query branch February 5, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OleksandrHladchenko1 OleksandrHladchenko1 OleksandrHladchenko1 approved these changes

@SergeYvas SergeYvas SergeYvas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vashjs @SergeYvas @OleksandrHladchenko1