Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIBULKED-246 Displaying and paginating through retrieved records #463

Merged
merged 9 commits into from
Jan 30, 2024

Conversation

vashjs
Copy link
Contributor

@vashjs vashjs commented Jan 28, 2024

Previously, only 10 records were visible at all steps of bulk-edit. After this PR is merged, we will be able to see pagination at every step. Ref: UIBULKED-246

UPLOAD STEP

image

UPDATE STEP

image

COMMIT STEP

image

Copy link

github-actions bot commented Jan 28, 2024

Jest Unit Test Statistics

    1 files  ±0    32 suites  +2   2m 59s ⏱️ +4s
192 tests +7  191 ✔️ +7  1 💤 ±0  0 ±0 
195 runs  +7  194 ✔️ +7  1 💤 ±0  0 ±0 

Results for commit 69815e6. ± Comparison against base commit e72c901.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jan 28, 2024

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit 69815e6. ± Comparison against base commit e72c901.

♻️ This comment has been updated with latest results.

# Conflicts:
#	CHANGELOG.md
#	src/constants/core.js
#	src/hooks/api/useRecordsPreview.js
@vashjs vashjs requested review from UladzislauKutarkin and a team January 29, 2024 09:50
@vashjs vashjs removed the request for review from a team January 29, 2024 10:15
@vashjs vashjs requested a review from a team January 29, 2024 10:48
@NikitaSedyx NikitaSedyx requested a review from a team January 30, 2024 09:02
@vashjs vashjs requested a review from SergeYvas January 30, 2024 09:11
@@ -0,0 +1,14 @@
import { useState, useCallback } from 'react';

export const usePagination = ({ limit, offset }) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not covered by tests

import { EDITING_STEPS } from '../constants';
import { RootContext } from '../context/RootContext';

export const useBulkOperationStats = ({ bulkDetails, step }) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not covered by tests

Copy link

@vashjs vashjs merged commit 4c0143e into master Jan 30, 2024
6 checks passed
@vashjs vashjs deleted the UIBULKED-246 branch January 30, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants