Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIBULKED-349 add missed permission, translation and modify query #412

Merged
merged 16 commits into from
Nov 16, 2023

Conversation

vashjs
Copy link
Contributor

@vashjs vashjs commented Nov 15, 2023

Purpose

Some parts were missed in initial inplementation of UIBULKED-349. CHANGELOG already updated.

  1. added translation
  2. added permission
  3. updated query
  4. sorted by name

Approach

TODOS and Open Questions

Learning

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@vashjs vashjs requested review from UladzislauKutarkin and a team November 15, 2023 14:01
Copy link

github-actions bot commented Nov 15, 2023

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit 6cbe2eb. ± Comparison against base commit 71538d9.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 15, 2023

Jest Unit Test Statistics

    1 files  ±0    25 suites  ±0   2m 44s ⏱️ -2s
167 tests ±0  166 ✔️ ±0  1 💤 ±0  0 ±0 
170 runs  ±0  169 ✔️ ±0  1 💤 ±0  0 ±0 

Results for commit 6cbe2eb. ± Comparison against base commit 71538d9.

♻️ This comment has been updated with latest results.

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@vashjs vashjs merged commit a8eb75f into master Nov 16, 2023
6 checks passed
@vashjs vashjs deleted the UIBULKED-349 branch November 16, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants