UIBULKED-349 Update Electronic access - URL relationship

[vashjs]

Purpose

After this PR merged, then new URL Relationship option will be added. Once selected it should contain all actions and behave based on UIBULKED-349 requirements.

• Tests refactored
• Some string literals replaced with constants
• Some functions names were unified

Approach

TODOS and Open Questions

Learning

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

• I've added appropriate record to the CHANGELOG.md
• Does this PR meet or exceed the expected quality standards?
  • Code coverage on new code is 80% or greater
  • Duplications on new code is 3% or less
  • There are no major code smells or security issues
• Does this introduce breaking changes?
  • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
  • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

• What other modules will these changes impact?
• Do JIRAs exist to update the impacted modules?
  • If not, please create them
  • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
  • Do they have all they appropriate links to blocked/related issues?
• Are the JIRAs under active development?
  • If not, contact the project's PO and make sure they're aware of the urgency.
• Do PRs exist for these changes?
  • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

[github-actions]

Jest Unit Test Statistics

    1 files  ±0    25 suites  ±0   1m 38s ⏱️ -37s
167 tests +5  166 ✔️ +5  1 💤 ±0  0 ❌ ±0 
170 runs  +5  169 ✔️ +5  1 💤 ±0  0 ❌ ±0 

Results for commit 8040b4f. ± Comparison against base commit f2bef8f.

This pull request removes 3 and adds 8 tests. Note that renamed tests count towards both.

ContentUpdatesForm helpers helpers getDefaultActions returns the correct object for the URI option ‑ ContentUpdatesForm helpers helpers getDefaultActions returns the correct object for the URI option
ContentUpdatesForm helpers helpers getExtraActions should return a certain structure for specific OPTIONS and ACTIONS ‑ ContentUpdatesForm helpers helpers getExtraActions should return a certain structure for specific OPTIONS and ACTIONS
ValuesColumn Component should render select with item note types when action type is LOAN_TYPE ‑ ValuesColumn Component should render select with item note types when action type is LOAN_TYPE

ContentUpdatesForm helpers helpers getDefaultActions returns the correct object for the ELECTRONIC_ACCESS_URI option ‑ ContentUpdatesForm helpers helpers getDefaultActions returns the correct object for the ELECTRONIC_ACCESS_URI option
ContentUpdatesForm helpers helpers getDefaultActions returns the correct object for the ELECTRONIC_ACCESS_URL_RELATIONSHIP option ‑ ContentUpdatesForm helpers helpers getDefaultActions returns the correct object for the ELECTRONIC_ACCESS_URL_RELATIONSHIP option
ContentUpdatesForm helpers helpers getExtraActions should return a certain structure for specific OPTIONS and ACTIONS - Notes ‑ ContentUpdatesForm helpers helpers getExtraActions should return a certain structure for specific OPTIONS and ACTIONS - Notes
ContentUpdatesForm helpers helpers getExtraActions should return a certain structure for specific OPTIONS and ACTIONS - URL Relationship ‑ ContentUpdatesForm helpers helpers getExtraActions should return a certain structure for specific OPTIONS and ACTIONS - URL Relationship
ValuesColumn Component should render TextArea when action type is TEXTAREA ‑ ValuesColumn Component should render TextArea when action type is TEXTAREA
ValuesColumn Component should render select with item note types when action type is NOTE_SELECT + HOLDINS CAPABILITY ‑ ValuesColumn Component should render select with item note types when action type is NOTE_SELECT + HOLDINS CAPABILITY
ValuesColumn Component should render select with item note types when action type is NOTE_SELECT ‑ ValuesColumn Component should render select with item note types when action type is NOTE_SELECT
ValuesColumn Component should render select with url relationship types when action type is FIND ‑ ValuesColumn Component should render select with url relationship types when action type is FIND

♻️ This comment has been updated with latest results.

[github-actions]

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 8040b4f. ± Comparison against base commit f2bef8f.

♻️ This comment has been updated with latest results.

[Terala-Priyanka]

Could you add more unit tests to improve the coverage on files helpers.js and ValuesColumn.js

[vashjs]

Could you add more unit tests to improve the coverage on files helpers.js and ValuesColumn.js

@Terala-Priyanka The effort spent on achieving these few percents is much greater than the potential benefits of these tests. Coverage will be increased in a crowd of other stories.

[vashjs]

@mariia-aloshyna selectors for test updated, thanks for pointing it.

[sonarqubecloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

75.9% Coverage
0.0% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint