Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIBULKED-377: Not all note types are displayed using "Change note type" #408

Merged
merged 2 commits into from
Nov 9, 2023
Merged

UIBULKED-377: Not all note types are displayed using "Change note type" #408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bdc2695
UIBULKED-377: Not all note types are displayed using "Change note type"
UladzislauKutarkin Nov 9, 2023
118b744
UIBULKED-377: update CHANGELOG.md
UladzislauKutarkin Nov 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
* [UIBULKED-331](https://issues.folio.org/browse/UIBULKED-331) Bulk edit actions for holdings notes - add and remove notes.
* [UIBULKED-332](https://issues.folio.org/browse/UIBULKED-332) Bulk edit actions for holdings notes - find and replace or remove.
* [UIBULKED-333](https://issues.folio.org/browse/UIBULKED-333) Bulk edit actions for holdings notes - change note type.
* [UIBULKED-377](https://issues.folio.org/browse/UIBULKED-377) Not all note types are displayed using "Change note type".

## [4.0.0](https://github.com/folio-org/ui-bulk-edit/tree/v4.0.0) (2023-10-12)

Expand Down
12 changes: 0 additions & 12 deletions ...mponents/BulkEditList/BulkEditListResult/BulkEditInApp/ContentUpdatesForm/ValuesColumn.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,17 +204,6 @@ export const ValuesColumn = ({ action, actionIndex, onChange, option }) => {
/>
);

const renderNoteHoldingsTypeSelect = () => controlType === CONTROL_TYPES.HOLDINGS_NOTE && (
<Select
id="noteHoldingsType"
value={action.value}
loading={isHoldingsNotesLoading}
onChange={e => onChange({ actionIndex, value: e.target.value, fieldName: FIELD_VALUE_KEY })}
dataOptions={sortedHoldingsNotes}
aria-label={formatMessage({ id: 'ui-bulk-edit.ariaLabel.loanTypeSelect' })}
/>
);

return (
<Col xs={2} sm={2}>
{renderTextField()}
Expand All @@ -226,7 +215,6 @@ export const ValuesColumn = ({ action, actionIndex, onChange, option }) => {
{renderLoanTypeSelect()}
{renderNoteTypeSelect()}
{renderNoteDuplicateTypeSelect()}
{renderNoteHoldingsTypeSelect()}
</Col>
);
};
Expand Down
2 changes: 1 addition & 1 deletion src/components/BulkEditList/BulkEditListResult/BulkEditInApp/ContentUpdatesForm/helpers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ export const getDefaultActions = (option, options, formatMessage) => {
actionsList: noteWithMarkDefaultActions,
controlType: (action) => {
return action === ACTIONS.CHANGE_TYPE
? CONTROL_TYPES.HOLDINGS_NOTE
? CONTROL_TYPES.NOTE_SELECT
: CONTROL_TYPES.TEXTAREA;
},
[ACTION_VALUE_KEY]: noteWithMarkDefaultActions[0].value,
Expand Down
1 change: 0 additions & 1 deletion src/constants/core.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ export const CONTROL_TYPES = {
TEXTAREA: 'TEXTAREA',
NOTE_SELECT: 'NOTE_SELECT',
NOTE_DUPLICATE_SELECT: 'NOTE_DUPLICATE_SELECT',
HOLDINGS_NOTE: 'HOLDINGS_NOTE'
};

export const TRANSLATION_SUFFIX = {
Expand Down
Loading