UIBULKED-353: Update Electronic access - URI #406
Conversation
Screen.Recording.2023-11-08.at.10.47.04.mov |
| @@ -537,6 +537,37 @@ describe('ContentUpdatesForm helpers', () => { | |||
| ); | |||
| }); | |||
|
|
|||
| it('returns the correct object for the URI option', () => { | |||
| expect(JSON.stringify(getDefaultActions(OPTIONS.URI, [], formatMessage))).toEqual( | |||
There was a problem hiding this comment.
toEqual already performs deep equality, so there's no need for JSON.stringify
There was a problem hiding this comment.
Yes, I know, but we use JSON stringify here because we need to check the string. Without it, our main function returns a slightly different string, with the same content, but the test is not passing. You can take a look at all tests in helpers.js, we are using the same approach.
Here I can't do more, because I cant test control component staff. |
|
SonarCloud Quality Gate failed.
|
UIBULKED-353
Purpose
Approach
TODOS and Open Questions
Learning
Pre-Merge Checklist
Before merging this PR, please go through the following list and take appropriate actions.
If there are breaking changes, please STOP and consider the following:
Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.