Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIBULKED-316: Bulk edit actions for holdings notes - add and remove Mark as staff only #401

Merged
merged 13 commits into from
Oct 31, 2023

Conversation

UladzislauKutarkin
Copy link
Contributor

@UladzislauKutarkin UladzislauKutarkin commented Oct 24, 2023

UIBULKED-316
UIBULKED-331
UIBULKED-332
UIBULKED-333

Purpose

Approach

TODOS and Open Questions

Learning

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@UladzislauKutarkin UladzislauKutarkin requested review from vashjs and a team October 24, 2023 19:30
@github-actions
Copy link

github-actions bot commented Oct 24, 2023

Jest Unit Test Statistics

    1 files  ±0    25 suites  ±0   1m 46s ⏱️ +3s
161 tests +1  160 ✔️ +1  1 💤 ±0  0 ±0 
164 runs  +1  163 ✔️ +1  1 💤 ±0  0 ±0 

Results for commit f78fed2. ± Comparison against base commit 60c1271.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 24, 2023

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit f78fed2. ± Comparison against base commit 60c1271.

♻️ This comment has been updated with latest results.

@UladzislauKutarkin
Copy link
Contributor Author

@folio-org/fe-tl-reviewers and @vashjs While reducing code smells, I reused existing parts of code and just added change in switch case block in helpers, so all actions for holdings notes. Also, I attached the video

Screen.Recording.2023-10-25.at.11.07.19.mov

@UladzislauKutarkin UladzislauKutarkin requested a review from a team October 26, 2023 07:11
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

75.0% 75.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@UladzislauKutarkin UladzislauKutarkin merged commit 7f54e65 into master Oct 31, 2023
4 of 5 checks passed
@UladzislauKutarkin UladzislauKutarkin deleted the UIBULKED-316 branch October 31, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants