UIBULKED-315 Group holdings record properties using optgroup component #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
zburke
requested changes
Oct 16, 2023
| }); | ||
|
|
||
| return { | ||
| holdingNotes, |
There was a problem hiding this comment.
For consistency in naming, I think this should be holdingsNotes rather than holdingNotes. What do you think?
| label: formatMessage({ id: 'ui-bulk-edit.layer.options.holdings.temporaryLocation' }), | ||
| disabled: false }, | ||
| disabled: false, | ||
| categoryName: 'Holdings location' |
| { | ||
| value: OPTIONS.PERMANENT_HOLDINGS_LOCATION, | ||
| label: formatMessage({ id: 'ui-bulk-edit.layer.options.holdings.permanentLocation' }), | ||
| disabled: false, | ||
| categoryName: 'Holdings location' |
|
@zburke thanks for your commets, it was merged by mistake. All your comments makes sense and will be addressed! Don't have an idea why it's possible merge without approval.. |
11 tasks
I'll follow up with DevOps on that one. I'm curious about it too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
https://issues.folio.org/browse/UIBULKED-315
After this PR we will have holdings notes in select + grouping:
Approach
TODOS and Open Questions
Learning
Pre-Merge Checklist
Before merging this PR, please go through the following list and take appropriate actions.
If there are breaking changes, please STOP and consider the following:
Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.