Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIBULKED-312: CSV: On cancel button click uploaded file should be deleted #381

Merged
merged 5 commits into from
Sep 12, 2023

Conversation

UladzislauKutarkin
Copy link
Contributor

UIBULKED-312

Purpose

Approach

TODOS and Open Questions

Learning

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@UladzislauKutarkin UladzislauKutarkin requested a review from a team September 11, 2023 08:54
@github-actions
Copy link

github-actions bot commented Sep 11, 2023

Jest Unit Test Statistics

    1 files  ±0    25 suites  ±0   2m 2s ⏱️ +13s
160 tests ±0  159 ✔️ ±0  1 💤 ±0  0 ±0 
163 runs  ±0  162 ✔️ ±0  1 💤 ±0  0 ±0 

Results for commit 8a032ec. ± Comparison against base commit 85d96cd.

♻️ This comment has been updated with latest results.

@github-actions

This comment has been minimized.

@github-actions
Copy link

github-actions bot commented Sep 11, 2023

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit 8a032ec. ± Comparison against base commit 85d96cd.

♻️ This comment has been updated with latest results.

@OleksandrHladchenko1 OleksandrHladchenko1 requested a review from a team September 11, 2023 09:05
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

50.0% 50.0% Coverage
0.0% 0.0% Duplication

@UladzislauKutarkin UladzislauKutarkin merged commit 18c9129 into master Sep 12, 2023
5 checks passed
@UladzislauKutarkin UladzislauKutarkin deleted the UIBULKED-312 branch September 12, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants