Skip to content

Commit

Permalink
UIBULKED-372: Bulk edit - Element IDs are not unique.
Browse files Browse the repository at this point in the history
  • Loading branch information
UladzislauKutarkin committed Nov 8, 2023
1 parent 7f54e65 commit 5d6986a
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
* [UIBULKED-331](https://issues.folio.org/browse/UIBULKED-331) Bulk edit actions for holdings notes - add and remove notes.
* [UIBULKED-332](https://issues.folio.org/browse/UIBULKED-332) Bulk edit actions for holdings notes - find and replace or remove.
* [UIBULKED-333](https://issues.folio.org/browse/UIBULKED-333) Bulk edit actions for holdings notes - change note type.
* [UIBULKED-372](https://issues.folio.org/browse/UIBULKED-372) Bulk edit - Element IDs are not unique.

## [4.0.0](https://github.com/folio-org/ui-bulk-edit/tree/v4.0.0) (2023-10-12)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ const BulkEditInAppPreviewModal = ({
const history = useHistory();
const search = new URLSearchParams(history.location.search);
const capabilities = search.get('capabilities');
const step = search.get('step');
const { visibleColumns } = useContext(RootContext);

const swwCallout = () => (
Expand Down Expand Up @@ -176,6 +177,7 @@ const BulkEditInAppPreviewModal = ({
columnMapping={columnMapping}
visibleColumns={visibleColumnKeys}
maxHeight={300}
columnIdPrefix={step}
/>
</>
) : <Preloader />}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ export const Preview = ({ id, title, isInitial, bulkDetails }) => {
contentData={contentData}
columnMapping={columnMapping}
visibleColumns={visibleColumns}
step={step}
/>
)}
{Boolean(errors?.length) && (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import {
} from '@folio/stripes/components';


const PreviewAccordion = ({ contentData, columnMapping, visibleColumns, isInitial }) => {
const PreviewAccordion = ({ contentData, columnMapping, visibleColumns, isInitial, step }) => {
const translationKey = isInitial ? 'title' : 'titleChanged';
const maxHeight = window.innerHeight * 0.4;

Expand All @@ -31,6 +31,7 @@ const PreviewAccordion = ({ contentData, columnMapping, visibleColumns, isInitia
columnMapping={columnMapping}
visibleColumns={visibleColumnKeys}
maxHeight={maxHeight}
columnIdPrefix={step}
/>
</Col>
</Row>
Expand All @@ -43,6 +44,7 @@ PreviewAccordion.propTypes = {
columnMapping: PropTypes.object,
visibleColumns: PropTypes.arrayOf(PropTypes.object),
isInitial: PropTypes.bool,
step: PropTypes.string,
};

export default memo(PreviewAccordion);
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ const renderPreviewAccordion = ({
visibleColumns={visibleColumns}
columnMapping={columnMapping}
initial={initial}
step="UPLOAD"
/>
</RootContext.Provider>,
);
Expand Down

0 comments on commit 5d6986a

Please sign in to comment.