UIBULKED-377: Not all note types are displayed using "Change note typ…

…e" (#408)
folio-org · Nov 9, 2023 · 488635a · 488635a
1 parent 7f54e65
commit 488635a
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 14 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -10,6 +10,7 @@
 * [UIBULKED-331](https://issues.folio.org/browse/UIBULKED-331) Bulk edit actions for holdings notes - add and remove notes.
 * [UIBULKED-332](https://issues.folio.org/browse/UIBULKED-332) Bulk edit actions for holdings notes - find and replace or remove.
 * [UIBULKED-333](https://issues.folio.org/browse/UIBULKED-333) Bulk edit actions for holdings notes - change note type.
+* [UIBULKED-377](https://issues.folio.org/browse/UIBULKED-377) Not all note types are displayed using "Change note type".
 
 ## [4.0.0](https://github.com/folio-org/ui-bulk-edit/tree/v4.0.0) (2023-10-12)
 

diff --git a/...mponents/BulkEditList/BulkEditListResult/BulkEditInApp/ContentUpdatesForm/ValuesColumn.js b/...mponents/BulkEditList/BulkEditListResult/BulkEditInApp/ContentUpdatesForm/ValuesColumn.js
@@ -204,17 +204,6 @@ export const ValuesColumn = ({ action, actionIndex, onChange, option }) => {
   />
   );
 
-  const renderNoteHoldingsTypeSelect = () => controlType === CONTROL_TYPES.HOLDINGS_NOTE && (
-    <Select
-      id="noteHoldingsType"
-      value={action.value}
-      loading={isHoldingsNotesLoading}
-      onChange={e => onChange({ actionIndex, value: e.target.value, fieldName: FIELD_VALUE_KEY })}
-      dataOptions={sortedHoldingsNotes}
-      aria-label={formatMessage({ id: 'ui-bulk-edit.ariaLabel.loanTypeSelect' })}
-    />
-  );
-
   return (
     <Col xs={2} sm={2}>
       {renderTextField()}
@@ -226,7 +215,6 @@ export const ValuesColumn = ({ action, actionIndex, onChange, option }) => {
       {renderLoanTypeSelect()}
       {renderNoteTypeSelect()}
       {renderNoteDuplicateTypeSelect()}
-      {renderNoteHoldingsTypeSelect()}
     </Col>
   );
 };

diff --git a/src/components/BulkEditList/BulkEditListResult/BulkEditInApp/ContentUpdatesForm/helpers.js b/src/components/BulkEditList/BulkEditListResult/BulkEditInApp/ContentUpdatesForm/helpers.js
@@ -282,7 +282,7 @@ export const getDefaultActions = (option, options, formatMessage) => {
             actionsList: noteWithMarkDefaultActions,
             controlType: (action) => {
               return action === ACTIONS.CHANGE_TYPE
-                ? CONTROL_TYPES.HOLDINGS_NOTE
+                ? CONTROL_TYPES.NOTE_SELECT
                 : CONTROL_TYPES.TEXTAREA;
             },
             [ACTION_VALUE_KEY]: noteWithMarkDefaultActions[0].value,

diff --git a/src/constants/core.js b/src/constants/core.js
@@ -75,7 +75,6 @@ export const CONTROL_TYPES = {
   TEXTAREA: 'TEXTAREA',
   NOTE_SELECT: 'NOTE_SELECT',
   NOTE_DUPLICATE_SELECT: 'NOTE_DUPLICATE_SELECT',
-  HOLDINGS_NOTE: 'HOLDINGS_NOTE'
 };
 
 export const TRANSLATION_SUFFIX = {