UIBULKED-538 “Are you sure" form notification banner wording for the …

…case of bulk editing MARC fields for FOLIO Instances (follow up) (#644) (cherry picked from commit 7b4adba)
folio-org · Nov 15, 2024 · 1c3ffe6 · 1c3ffe6
1 parent f0ccb0d
commit 1c3ffe6
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/src/components/BulkEditActionMenu/BulkEditActionMenu.js b/src/components/BulkEditActionMenu/BulkEditActionMenu.js
@@ -76,9 +76,9 @@ const BulkEditActionMenu = ({
   const isStartBulkInAppActive =
        hasEditPerm
     && isInitialStep
-    && [JOB_STATUSES.DATA_MODIFICATION, JOB_STATUSES.REVIEW_CHANGES].includes(bulkDetails?.status);
+    && [JOB_STATUSES.DATA_MODIFICATION, JOB_STATUSES.REVIEW_CHANGES, JOB_STATUSES.REVIEWED_NO_MARC_RECORDS].includes(bulkDetails?.status);
   const isStartMarkActive = (isStartBulkInAppActive || hasInstanceAndMarcEditPerm || hasInventoryAndMarcEditPerm) && currentRecordType === CAPABILITIES.INSTANCE && isInitialStep
-  && [JOB_STATUSES.DATA_MODIFICATION, JOB_STATUSES.REVIEW_CHANGES].includes(bulkDetails?.status);
+  && [JOB_STATUSES.DATA_MODIFICATION, JOB_STATUSES.REVIEW_CHANGES, JOB_STATUSES.REVIEWED_NO_MARC_RECORDS].includes(bulkDetails?.status);
 
   const isStartManualButtonVisible = isStartBulkCsvActive && isInitialStep && countOfRecords > 0 && criteria !== CRITERIA.QUERY && !isESC;
 

diff --git a/...nts/BulkEditPane/BulkEditListResult/BulkEditInAppPreviewModal/BulkEditPreviewModalList.js b/...nts/BulkEditPane/BulkEditListResult/BulkEditInAppPreviewModal/BulkEditPreviewModalList.js
@@ -17,7 +17,6 @@ import { PREVIEW_COLUMN_WIDTHS } from '../../../PermissionsModal/constants/lists
 import css from './BulkEditInAppPreviewModal.css';
 import { usePagination } from '../../../../hooks/usePagination';
 import {
-  CAPABILITIES,
   EDITING_STEPS,
   JOB_STATUSES,
   PAGINATION_CONFIG
@@ -53,7 +52,7 @@ export const BulkEditPreviewModalList = ({
   });
 
   const visibleColumnKeys = getVisibleColumnsKeys(visibleColumns);
-  const enabled = bulkDetails?.status === JOB_STATUSES.REVIEW_CHANGES;
+  const enabled = [JOB_STATUSES.REVIEWED_NO_MARC_RECORDS, JOB_STATUSES.REVIEW_CHANGES].includes(bulkDetails?.status);
 
   const {
     contentData,
@@ -81,7 +80,7 @@ export const BulkEditPreviewModalList = ({
   if (!contentData) return <Preloader />;
 
   const renderMessageBanner = () => {
-    if (!bulkDetails?.processedNumOfRecords && currentRecordType === CAPABILITIES.INSTANCE) {
+    if (bulkDetails?.status === JOB_STATUSES.REVIEWED_NO_MARC_RECORDS) {
       return (
         <MessageBanner type="warning">
           <FormattedMessage id="ui-bulk-edit.previewModal.message.empty.marc" />

diff --git a/src/constants/core.js b/src/constants/core.js
@@ -50,6 +50,7 @@ export const JOB_STATUSES = {
   SAVING_RECORDS_LOCALLY: 'SAVING_RECORDS_LOCALLY',
   DATA_MODIFICATION: 'DATA_MODIFICATION',
   REVIEW_CHANGES: 'REVIEW_CHANGES',
+  REVIEWED_NO_MARC_RECORDS: 'REVIEWED_NO_MARC_RECORDS',
   APPLY_CHANGES: 'APPLY_CHANGES',
   SUSPENDED: 'SUSPENDED',
   COMPLETED: 'COMPLETED',

diff --git a/translations/ui-bulk-edit/en.json b/translations/ui-bulk-edit/en.json
@@ -431,7 +431,7 @@
   "actionMenu.placeholder": "Search column name",
 
   "previewModal.message": "{count, number} records will be changed if the Commit changes button is clicked. You may choose Download preview to review all changes prior to saving.",
-  "previewModal.message.empty.marc": "All instances have source FOLIO.  Use “Instances and  Administrative data” option for bulk edit.",
+  "previewModal.message.empty.marc": "All instances have source FOLIO. Use “Instances and  Administrative data” option for bulk edit.",
   "previewModal.previewToBeChanged": "Preview of records to be changed",
   "previewModal.keepEditing": "Keep editing",
   "previewModal.downloadPreview": "Download preview",