STRWEB-90 omit css alias cruft #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't manipulate `config.resolve.extensions` for the benefit of CSS because it appears we're not actually leveraging it anywhere. Additional spot-testing across a variety of applications doesn't show any of the odd problems we saw when we first tried to clean this up in STRWEB-85. Refs STRWEB-90
artem-blazhko
approved these changes
Oct 24, 2023
UladzislauKutarkin
approved these changes
Oct 24, 2023
|
@JohnC-80, @EthanFreestone, I would love for you two to weigh in on this. |
Apologies for the later reply, only just saw this. Change looks good to me, have tested locally without incident so AFAIC it's good to go :D |
EthanFreestone
approved these changes
Oct 31, 2023
|
Thanks, @EthanFreestone. Can you or @JohnC-80 also approve #130 so I can get the version bumped on master? I'll merge this as soon as that is taken care of. |
Have approved the version bump :) |
JohnC-80
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't manipulate
config.resolve.extensionsfor the benefit of CSS because it appears we're not actually leveraging it anywhere. Additional spot-testing across a variety of applications doesn't show any of the odd problems we saw when we first tried to clean this up in STRWEB-85.Refs STRWEB-90