Skip to content

Commit

Permalink
STRWEB-105 lock favicons to v7.1.4 to avoid build failures (#135)
Browse files Browse the repository at this point in the history
`favicons` `v7.1.5` bumps `sharp` from `v0.32.6` to `v0.33.1` and ain't
nothin' building anymore. See also itgalaxy/favicons#448.
Jenkins errors look like
```
/home/jenkins/workspace/Automation/build-platform-complete-snapshot/node_modules/favicons-webpack-plugin/src/index.js:656
    throw new Error(
          ^

Error: Could not find the npm peerDependency "favicons".
Please run:
npm i favicons
 - or -
yarn add favicons

Error: Could not load the "sharp" module using the linux-x64 runtime
Possible solutions:
- Ensure optional dependencies can be installed:
    npm install --include=optional sharp
    yarn add sharp --ignore-engines
- Ensure your package manager supports multi-platform installation:
    See https://sharp.pixelplumbing.com/install#cross-platform
- Add platform-specific dependencies:
    npm install --os=linux --cpu=x64 sharp
    npm install --force @img/sharp-linux-x64
- Consult the installation documentation:
    See https://sharp.pixelplumbing.com/install
    at loadFaviconsLibrary (/home/jenkins/workspace/Automation/build-platform-complete-snapshot/node_modules/favicons-webpack-plugin/src/index.js:656:11)
    at #generateFaviconsWebapp (/home/jenkins/workspace/Automation/build-platform-complete-snapshot/node_modules/favicons-webpack-plugin/src/index.js:454:26)
    at #generateFavicons (/home/jenkins/workspace/Automation/build-platform-complete-snapshot/node_modules/favicons-webpack-plugin/src/index.js:376:44)
    at /home/jenkins/workspace/Automation/build-platform-complete-snapshot/node_modules/favicons-webpack-plugin/src/index.js:164:42
    at /home/jenkins/workspace/Automation/build-platform-complete-snapshot/node_modules/favicons-webpack-plugin/src/cache.js:150:5
    at CacheFacade.providePromise (/home/jenkins/workspace/Automation/build-platform-complete-snapshot/node_modules/webpack/lib/CacheFacade.js:341:24)

Node.js v18.17.1
error Command failed with exit code 1.
```
and similar errors occur in local development builds in other OSes.

Refs STRWEB-105

(cherry picked from commit 7b54dd8)
  • Loading branch information
zburke committed Jan 12, 2024
1 parent f249e22 commit e275016
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Change history for stripes-webpack

## 5.0.2 IN PROGRESS

* Lock `favicons` to `7.1.4` due to build failures. Refs STRWEB-105.

## [5.0.1](https://github.com/folio-org/stripes-webpack/tree/v5.0.1) (2023-11-06)
[Full Changelog](https://github.com/folio-org/stripes-webpack/compare/v5.0.0...v5.0.1)

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
"debug": "^4.0.1",
"esbuild-loader": "~3.0.1",
"express": "^4.14.0",
"favicons": "^7.1.2",
"favicons": "7.1.4",
"favicons-webpack-plugin": "^6.0.0",
"handlebars": "^4.7.7",
"handlebars-loader": "^1.7.1",
Expand Down

0 comments on commit e275016

Please sign in to comment.