STSMACOM-879 Use this.resources in StripesConnectedSource instead of accessing props directly.
#1544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of accessing props directly.
|
Dmytro-Melnyshyn
approved these changes
Nov 28, 2024
UladzislauKutarkin
approved these changes
Nov 28, 2024
zburke
pushed a commit
that referenced
this pull request
Dec 5, 2024
… of accessing props directly. (#1544) `StripesConnectedSource` can accept either `parentResources` or `resources` and one of them can be undefined. Because of this we should use `this.resources` instead, which takes this into account https://github.com/user-attachments/assets/ec30f55d-c9b2-4643-afd6-ca3d663eb68b [STSMACOM-879](https://folio-org.atlassian.net/browse/STSMACOM-879) (cherry picked from commit 3fd7f0c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
StripesConnectedSourcecan accept eitherparentResourcesorresourcesand one of them can be undefined. Because of this we should usethis.resourcesinstead, which takes this into accountScreenshots
chrome_pMMEOXrGvn.mp4
Issues
STSMACOM-879