Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STCOR-926 validate that cookies and storage are available #1581

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

zburke
Copy link
Member

@zburke zburke commented Jan 6, 2025

Detect the presence of localStorage, sessionStorage, and cookies early early early in the stripes-init process and show an error message if any are unavailable.

This prevents a white screen of death if, say, session storage is unavailable but we call it anyway, resulting in an untrapped exception (Here's looking at you, OIDCRedirect).

Refs STCOR-926

Detect the presence of localStorage, sessionStorage, and cookies early
early early in the stripes-init process and show an error message if any
are unavailable.

This prevents a white screen of death if, say, session storage is
unavailable but we call it anyway, resulting in an untrapped exception
(Here's looking at you, OIDCRedirect).

Refs STCOR-926
@zburke zburke requested a review from a team as a code owner January 6, 2025 20:19
Copy link

github-actions bot commented Jan 6, 2025

Bigtest Unit Test Results

189 tests  ±0   184 ✅ ±0   6s ⏱️ ±0s
  1 suites ±0     5 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit a7467d1. ± Comparison against base commit f7d2b36.

This pull request removes 5 and adds 3 tests. Note that renamed tests count towards both.
      equal to check email label in english translation
      equal to check email precautions label in english translation
      equal to sent email precautions label in english translation
Chrome_131_0_0_0_(Linux_x86_64).Forgot username/password status test check email status page tests ‑ Forgot username/password status test check email status page tests should have the header with an appropriate text content
Chrome_131_0_0_0_(Linux_x86_64).Forgot username/password status test check email status page tests ‑ Forgot username/password status test check email status page tests should have the paragraph with an appropriate text content
Chrome_131_0_0_0_(Linux_x86_64).Forgot username/password status test check email status page tests ‑ Forgot username/password status test check email status page tests should have the header with an appropriate text content
      equal to check email label in english translation
Chrome_131_0_0_0_(Linux_x86_64).Forgot username/password status test check email status page tests ‑ Forgot username/password status test check email status page tests should have the paragraph with an appropriate text content
      equal to check email precautions label in english translation
Chrome_131_0_0_0_(Linux_x86_64).Forgot username/password status test check email status page tests ‑ Forgot username/password status test check email status page tests should have the paragraph with an appropriate text content
      equal to sent email precautions label in english translation

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jan 6, 2025

Jest Unit Test Results

  1 files  ±0   61 suites  +2   1m 33s ⏱️ +2s
360 tests +5  360 ✅ +5  0 💤 ±0  0 ❌ ±0 
363 runs  +5  363 ✅ +5  0 💤 ±0  0 ❌ ±0 

Results for commit a7467d1. ± Comparison against base commit f7d2b36.

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant