Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STCOM-1195: <AdvancedSearchRow> - change aria-label for the input box to enter a search query and the Boolean operator dropdown. #2409

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Dmytro-Melnyshyn
Copy link
Contributor

@Dmytro-Melnyshyn Dmytro-Melnyshyn commented Dec 30, 2024

Description

<AdvancedSearchRow> - change aria-label for the input box to enter a search query and the Boolean operator dropdown.

Related PRs

folio-org/stripes-testing#4592

Issues

STCOM-1195

Screenshots

image

… to enter a search query and the Boolean operator dropdown.
@Dmytro-Melnyshyn Dmytro-Melnyshyn requested a review from a team as a code owner December 30, 2024 10:07
@Dmytro-Melnyshyn Dmytro-Melnyshyn requested a review from a team December 30, 2024 10:09
Copy link

github-actions bot commented Dec 30, 2024

Bigtest Unit Test Results

    1 files  ±0      1 suites  ±0   23s ⏱️ +8s
1 533 tests ±0  1 521 ✅  - 4  8 💤 ±0  4 ❌ +4 
1 535 runs  ±0  1 523 ✅  - 4  8 💤 ±0  4 ❌ +4 

For more details on these failures, see this check.

Results for commit 96f23b8. ± Comparison against base commit 22ab4bb.

This pull request removes 4 and adds 4 tests. Note that renamed tests count towards both.
Chrome_131_0_0_0_(Linux_x86_64).AdvancedSearch when making some changes to rows and searching ‑ AdvancedSearch when making some changes to rows and searching should call onSearch with corectly formatted data
Chrome_131_0_0_0_(Linux_x86_64).AdvancedSearch when resetting advanced search ‑ AdvancedSearch when resetting advanced search should clear rows
Chrome_131_0_0_0_(Linux_x86_64).AdvancedSearch when search options has a dot in name and opening advanced search again ‑ AdvancedSearch when search options has a dot in name and opening advanced search again should split it into several rows correctly
Chrome_131_0_0_0_(Linux_x86_64).AdvancedSearch when searching with query in first row ‑ AdvancedSearch when searching with query in first row should call onSearch with corectly formatted data
Chrome_131_0_0_0_(Linux_x86_64).AdvancedSearch when making some changes to rows and searching ‑ AdvancedSearch when making some changes to rows and searching "before each" hook for "should call onSearch with corectly formatted data"
Chrome_131_0_0_0_(Linux_x86_64).AdvancedSearch when resetting advanced search ‑ AdvancedSearch when resetting advanced search "before each" hook for "should clear rows"
Chrome_131_0_0_0_(Linux_x86_64).AdvancedSearch when search options has a dot in name and opening advanced search again ‑ AdvancedSearch when search options has a dot in name and opening advanced search again "before each" hook for "should split it into several rows correctly"
Chrome_131_0_0_0_(Linux_x86_64).AdvancedSearch when searching with query in first row ‑ AdvancedSearch when searching with query in first row "before each" hook for "should call onSearch with corectly formatted data"

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant