STCOM-1392 Use h3 instead of h1 for menu.
#2405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
github-actions bot
pushed a commit
that referenced
this pull request
Dec 20, 2024
We saw it coming. We did. Zak should've pressed me. We should have changed the default `labelTag` back then, in [STCOM-1191](https://folio-org.atlassian.net/browse/STCOM-1191). Despite so much documentation around the internet regarding the `<section>` tag and its contained heading supporting `h1-h6`, etc... there's a scarce amount of connection to the safety-first best-and-long-practiced pattern of ONE SINGLE H1 PER-PAGE! (regardless of visiblity status.) Regardless of what apparent outcome of articles like this ([`h2` is the apparent ceiling for `sections`, period](https://www.webucator.com/article/html-heading-levels-and-sectioning-content/)) Having multiple `<H1>`'s show up to any validator and expecting validators/audit tools of any kind to read the minds of browsers/browser developers/spec writers/developers everywhere... just set it to make sense if you view the mark-up. Since dropdowns are commonly used within panes (which conventionally hold `h2`'s as their header) defaulting to `h3` fits with the convention.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We saw it coming. We did. Zak should've pressed me. We should have changed the default
labelTagback then, in STCOM-1191. Despite so much documentation around the internet regarding the<section>tag and its contained heading supportingh1-h6, etc... there's a scarce amount of connection to the safety-first best-and-long-practiced pattern of ONE SINGLE H1 PER-PAGE! (regardless of visiblity status.) Regardless of what apparent outcome of articles like this (h2is the apparent ceiling forsections, period) Having multiple<H1>'s show up to any validator and expecting validators/audit tools of any kind to read the minds of browsers/browser developers/spec writers/developerseverywhere... just set it to make sense if you view the mark-up. Since dropdowns are commonly used within panes (which conventionally hold
h2's as their header) defaulting toh3fits with the convention.