STCOM-1379 pin currency-codes to avoid unexpected dupes #2383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Data that was uniquely keyed up through `v2.1.0` is not so in `v2.2.0` (there are multiple entries for the currency `Bolívar Soberano`). It is not clear if the uniqueness property was intentional or incidental. Since we have tests that directly rely on the data we import, we should _always_ depend on a specific version in order to avoid this kind of problem, and so we can choose when to address it instead of being forced to address it whenever the third-party dependency happens to publish a new release. Refs STCOM-1379
|
JohnC-80
approved these changes
Nov 1, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Nov 1, 2024
Data that was uniquely keyed up through `v2.1.0` is not so in `v2.2.0` (there are multiple entries for the currency `Bolívar Soberano`). It is not clear if the uniqueness property was intentional or incidental. Since we have tests that directly rely on the data we import, we should _always_ depend on a specific version in order to avoid this kind of problem, and so we can choose when to address it instead of being forced to address it whenever the third-party dependency happens to publish a new release. Refs STCOM-1379
zburke
added a commit
that referenced
this pull request
Nov 8, 2024
Data that was uniquely keyed up through `v2.1.0` is not so in `v2.2.0` (there are multiple entries for the currency `Bolívar Soberano`). It is not clear if the uniqueness property was intentional or incidental. Since we have tests that directly rely on the data we import, we should _always_ depend on a specific version in order to avoid this kind of problem, and so we can choose when to address it instead of being forced to address it whenever the third-party dependency happens to publish a new release. Refs STCOM-1379 (cherry picked from commit 651f68c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data that was uniquely keyed up through
v2.1.0is not so inv2.2.0(there are multiple entries for the currencyBolívar Soberano). It is not clear if the uniqueness property was intentional or incidental (see freeall/currency-codes#46).Since we have tests that directly rely on the data we import, we should always depend on a specific version in order to avoid this kind of problem, and so we can choose when to address it instead of being forced to address it whenever the third-party dependency happens to publish a new release.
Refs STCOM-1379