STCOM-1150v2 #2036
Open
STCOM-1150v2 #2036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR checks that the moment's active locale matches the lowercase version of the locale passed through props/intl before using its static locale. If not, it falls back to getting a localized time format from Browser Intl API.
momentdoesn't have anen-SElocale.. it falls back toenif it's attempted usingmoment.locale('en-SE')As far as time-picker is concerned, the discrepancy between them is thaten-SEis a 24 hour format, butenis 12 hour... accurate formatting info is provided from browser INTL API, however, so that's what we can fall back to.