-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STCOM-922: Add tabbed interface components #1718
base: master
Are you sure you want to change the base?
Conversation
This commit adds the ability to create tabbed interfaces, it is dependent on
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I noted some minor quibbles about arrangement of the components in a single file and the CSS import (tests would not run for me until I changed the variables
import), but everything else looks good to me. Nice work!
const tabPanel2 = await TabPanelInteractor('Panel 2'); | ||
await tab.click(); | ||
await Keyboard.arrowRight(); | ||
await tabPanel2.exists(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to assert tabPanel2.exists() === false
before arrowClick
? I'm new to this code, obvs, but it feels like all the tabs are created in mount
so testing exists()
feels funny.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I understand this. Are you saying I should test that tabPanel2
doesn't exist before the arrowRight()
that causes it to exist happens? If so, I agree! But I thought I should check before I did it. Thanks!
This commit responds to the first two points made by @zburke in the PR feedback: - Change CSS import to use local path - Split into separate components
We're going to have to move this to a non-fork branch to get CI to ultimately pass. Sonarcloud doesn't seem to want to run on forks. |
Andrew Isherwood seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This commit adds the ability to create tabbed interfaces, it is
dependent on by UITEST-90