add tests for removed filter value, updated comment

folio-org · Nov 21, 2024 · e197711 · e197711
1 parent 42b44fe
commit e197711
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/lib/MultiSelection/MultiSelection.js b/lib/MultiSelection/MultiSelection.js
@@ -256,7 +256,6 @@ const MultiSelection = ({
           break;
       }
     },
-    //
     stateReducer(state, actionAndChanges) {
       const { changes, type } = actionAndChanges
       switch (type) {
@@ -274,7 +273,7 @@ const MultiSelection = ({
             });
             setFilterValue('');
             return {
-              isOpen: false, // keep the menu open after selection.
+              isOpen: false, // close the menu.
               highlightedIndex, // don't move highlight cursor back to top of list on selection.
             }
           } else {

diff --git a/lib/MultiSelection/tests/MultiSelection-test.js b/lib/MultiSelection/tests/MultiSelection-test.js
@@ -610,6 +610,16 @@ describe('MultiSelect', () => {
 
       it('calls the action\'s onSelect function', () => converge(() => { if (!actionSelected) throw new Error('MultiSelection - action should be executed'); }));
     });
+
+    describe('clicking a filtered action', () => {
+      beforeEach(async () => {
+        await multiselection.filter('act');
+        await multiselection.select('actionItem');
+      });
+
+      it('calls the action\'s onSelect function', () => converge(() => { if (!actionSelected) throw new Error('MultiSelection - action should be executed'); }));
+      it('clears the filter value', () => multiselection.has({ filterValue: '' }));
+    });
   });
 
   describe('asyncFiltering', () => {