Paneset: check for existing id before registering pane

folio-org · Nov 22, 2024 · 2e61b74 · 2e61b74
1 parent a3e41cd
commit 2e61b74
Showing 1 changed file with 9 additions and 4 deletions.
diff --git a/lib/Paneset/Paneset.js b/lib/Paneset/Paneset.js
@@ -442,10 +442,15 @@ class Paneset extends React.Component {
           this.interval = null;
         });
       } else {
-        // insert sorted by left coordinate of clientrect...
-        const newPanes = insertByClientRect(newState.panes, paneObject);
-        newState = Object.assign(newState, { panes: newPanes, changeType: 'added' });
-        // newState = this.insertPaneObject(newState, paneObject);
+        // check for duplicate id's before registering. Registration happens on mount.
+        // This will help with mount-twice strict mode strangeness
+        const paneExists = newState.panes.findIndex((p) => p.id === paneObject.id)
+        if (paneExists === -1) {
+          // insert sorted by left coordinate of clientrect...
+          const newPanes = insertByClientRect(newState.panes, paneObject);
+          newState = Object.assign(newState, { panes: newPanes, changeType: 'added' });
+          // newState = this.insertPaneObject(newState, paneObject);
+        }
       }
       return newState;
     }, () => {