Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MODEXPW-452: Retrieve instance records based on provided list of ISBN/ISSN #503

Merged
merged 14 commits into from
Jan 12, 2024

Conversation

DmytroBykov1
Copy link
Contributor

@DmytroBykov1 DmytroBykov1 commented Jan 10, 2024

Purpose

https://issues.folio.org/browse/MODEXPW-452
Retrieve instance records based on provided list of supported identifiers (ISBN, ISSN)

Approach

  1. instance model - InstanceFormat;
  2. parser.

TODOS and Open Questions

Learning

Pre-Merge Checklist:

Before merging this PR, please go through the following list and take appropriate actions.

  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • Check logging
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • Were any API paths or methods changed, added or removed?
    • Were there any schema changes?
    • Did any of the interface versions change?
    • Were permissions changed, added, or removed?
    • Are there new interface dependencies?
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@DmytroBykov1 DmytroBykov1 self-assigned this Jan 10, 2024
@DmytroBykov1 DmytroBykov1 requested a review from a team January 10, 2024 15:36
@NikitaSedyx
Copy link
Contributor

PR name is malformed

@DmytroBykov1 DmytroBykov1 changed the title Modexpw 452 issn MODEXPW-452: Retrieve instance records based on provided list of ISBN/ISSN Jan 11, 2024
Copy link

@DmytroBykov1 DmytroBykov1 merged commit 38b472b into master Jan 12, 2024
6 checks passed
@DmytroBykov1 DmytroBykov1 deleted the MODEXPW-452_ISSN branch January 12, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants