Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIRCSTORE-539: added new request.item fields and db indexing into request schema #498

Merged
merged 6 commits into from
Dec 6, 2024
Merged

CIRCSTORE-539: added new request.item fields and db indexing into request schema #498

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4ebf740
CIRCSTORE-539: added new request.item fields and db indexing
kapil-epam Nov 29, 2024
fcd2784
Merge branch 'master' into CIRCSTORE-539
kapil-epam Dec 4, 2024
9a80571
CIRCSTORE-539: fixed PR comments
kapil-epam Dec 5, 2024
4f118c4
Merge remote-tracking branch 'origin/CIRCSTORE-539' into CIRCSTORE-539
kapil-epam Dec 5, 2024
021e9e4
CIRCSTORE-539: upgraded request-storage interface version from 6.1 to…
kapil-epam Dec 5, 2024
d109915
CIRCSTORE-539: fix sonar issue
kapil-epam Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ramls/examples/request.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,12 @@
"holdingsRecordId": "e63273e7-48f5-4c43-ab4e-1751ecacaa21",
"itemId": "195efae1-588f-47bd-a181-13a2eb437701",
"item": {
"barcode": "760932543816"
"barcode": "760932543816",
"itemEffectiveLocationId" : "758258bc-ecc1-41b8-abca-f7b610822ffd",
"itemEffectiveLocationName" : "XYZ Location",
"retrievalServicePointId" : "c4c90014-c8c9-4ade-8f24-b5e313319f4b",
"retrievalServicePointName" : "Circ Desk Test"

},
"position": 1,
"fulfillmentPreference": "Hold Shelf",
Expand Down
16 changes: 16 additions & 0 deletions ramls/request.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,22 @@
"barcode": {
"description": "barcode of the item",
"type": "string"
},
"itemEffectiveLocationId": {
"description": "Item's effective location",
"type": "string"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a pattern or $ref attributes for the ID's ? for e.g. "$ref": "raml-util/schemas/uuid.schema"

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test methods for these new additions in request schema.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed:=> 9a80571

},
"itemEffectiveLocationName": {
"description": "Item's effective location name",
"type": "string"
},
"retrievalServicePointId": {
"description": "Item's location primary service point",
"type": "string"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a pattern or $ref attributes for the ID's ? for e.g. "$ref": "raml-util/schemas/uuid.schema"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed:=> 9a80571

},
"retrievalServicePointName": {
"description": "Item's location primary service point name",
"type": "string"
}
},
"additionalProperties": false
Expand Down
48 changes: 48 additions & 0 deletions src/main/resources/templates/db_scripts/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,30 @@
"tOps": "ADD",
"caseSensitive": false,
"removeAccents": false
},
{
"fieldName": "item.itemEffectiveLocationId",
"tOps": "ADD",
"caseSensitive": false,
"removeAccents": false
},
{
"fieldName": "item.itemEffectiveLocationName",
"tOps": "ADD",
"caseSensitive": false,
"removeAccents": false
},
{
"fieldName": "item.retrievalServicePointId",
"tOps": "ADD",
"caseSensitive": false,
"removeAccents": false
},
{
"fieldName": "item.retrievalServicePointName",
"tOps": "ADD",
"caseSensitive": false,
"removeAccents": false
}
],
"fullTextIndex": [
Expand Down Expand Up @@ -298,6 +322,30 @@
"tOps": "ADD",
"caseSensitive": false,
"removeAccents": false
},
{
"fieldName": "item.itemEffectiveLocationId",
"tOps": "ADD",
"caseSensitive": false,
"removeAccents": false
},
{
"fieldName": "item.itemEffectiveLocationName",
"tOps": "ADD",
"caseSensitive": false,
"removeAccents": false
},
{
"fieldName": "item.retrievalServicePointId",
"tOps": "ADD",
"caseSensitive": false,
"removeAccents": false
},
{
"fieldName": "item.retrievalServicePointName",
"tOps": "ADD",
"caseSensitive": false,
"removeAccents": false
}
],
"customSnippetPath": "requestUpdateTrigger.sql"
Expand Down
Loading