-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CIRCSTORE-521] Publish request batch event when requests are reordered #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roman-barannyk
force-pushed
the
CIRCSTORE-521
branch
2 times, most recently
from
August 21, 2024 12:02
63f38ba
to
562cd90
Compare
roman-barannyk
force-pushed
the
CIRCSTORE-521
branch
from
August 21, 2024 12:03
562cd90
to
de0f3c6
Compare
roman-barannyk
requested review from
alexanderkurash,
OleksandrVidinieiev and
MagzhanArtykov
August 28, 2024 12:19
alexanderkurash
approved these changes
Aug 29, 2024
OleksandrVidinieiev
approved these changes
Aug 29, 2024
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
##Purpose
When the UI reorders requests, it calls the /circulation/requests/queue/instance/{instanceId}/reorder endpoint
This endpoint calls /request-storage-batch/requests from mod-circulation-storage, and after successful reordering, mod-circulation-storage should publish a Kafka request-batch-update event. The event's payload must include the instanceId and the IDs of the reordered requests
Resolves: CIRCSTORE-521