-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIRCSTORE-509: Create CRUD API for storing circulation settings #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MagzhanArtykov
requested review from
OleksandrVidinieiev,
roman-barannyk and
alexanderkurash
June 11, 2024 09:33
src/main/java/org/folio/persist/CirculationSettingsRepository.java
Outdated
Show resolved
Hide resolved
src/main/java/org/folio/service/CirculationSettingsService.java
Outdated
Show resolved
Hide resolved
src/main/java/org/folio/service/CirculationSettingsService.java
Outdated
Show resolved
Hide resolved
src/main/java/org/folio/service/CirculationSettingsService.java
Outdated
Show resolved
Hide resolved
src/main/java/org/folio/support/kafka/topic/CirculationStorageKafkaTopic.java
Outdated
Show resolved
Hide resolved
OleksandrVidinieiev
approved these changes
Jun 11, 2024
Co-authored-by: OleksandrVidinieiev <[email protected]>
Quality Gate passedIssues Measures |
alexanderkurash
approved these changes
Jun 11, 2024
alexanderkurash
added a commit
that referenced
this pull request
Jun 18, 2024
* CIRCSTORE-509 Create CRUD API for storing circulation settings * CIRCSTORE-509 Create CRUD API for storing circulation settings * CIRCSTORE-509 Create CRUD API for storing circulation settings * CIRCSTORE-509 Create CRUD API for storing circulation settings * CIRCSTORE-509 Create CRUD API for storing circulation settings * CIRCSTORE-509 Create CRUD API for storing circulation settings * CIRCSTORE-509 Create CRUD API for storing circulation settings * CIRCSTORE-509 Create CRUD API for storing circulation settings * CIRCSTORE-509 Create CRUD API for storing circulation settings * CIRCSTORE-509 Create CRUD API for storing circulation settings * CIRCSTORE-509 Create CRUD API for storing circulation settings * CIRCSTORE-509 Fix formatting Co-authored-by: OleksandrVidinieiev <[email protected]> --------- Co-authored-by: Alexander Kurash <[email protected]> Co-authored-by: OleksandrVidinieiev <[email protected]>
alexanderkurash
added a commit
that referenced
this pull request
Jun 19, 2024
* CIRCSTORE-509: Create CRUD API for storing circulation settings (#466) * CIRCSTORE-509 Create CRUD API for storing circulation settings * CIRCSTORE-509 Create CRUD API for storing circulation settings * CIRCSTORE-509 Create CRUD API for storing circulation settings * CIRCSTORE-509 Create CRUD API for storing circulation settings * CIRCSTORE-509 Create CRUD API for storing circulation settings * CIRCSTORE-509 Create CRUD API for storing circulation settings * CIRCSTORE-509 Create CRUD API for storing circulation settings * CIRCSTORE-509 Create CRUD API for storing circulation settings * CIRCSTORE-509 Create CRUD API for storing circulation settings * CIRCSTORE-509 Create CRUD API for storing circulation settings * CIRCSTORE-509 Create CRUD API for storing circulation settings * CIRCSTORE-509 Fix formatting Co-authored-by: OleksandrVidinieiev <[email protected]> --------- Co-authored-by: Alexander Kurash <[email protected]> Co-authored-by: OleksandrVidinieiev <[email protected]> * CIRCSTORE-515 Remove context config * CIRCSTORE-515 Remove RunWith * CIRCSTORE-515 Add test to the suite --------- Co-authored-by: Magzhan <[email protected]> Co-authored-by: OleksandrVidinieiev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Covers: CIRCSTORE-509
Purpose
Create a new API (GET, POST, PUT, DELETE) for storing circulation settings . It will be used for syncing ECS TLR setting (MODTLR-44) through consortia publications.