Circstore 506 #464
Merged
Circstore 506 #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SreejaMangarapu
requested review from
gurleenkaurbp,
SinghAdes,
Vignesh-kalyanasundaram,
alexanderkurash and
OleksandrVidinieiev
| @@ -93,6 +93,10 @@ | |||
| "description": "Indicates whether or not this loan had its due date modified by a recall on the loaned item", | |||
| "type": "boolean" | |||
| }, | |||
| "isDcb": { | |||
There was a problem hiding this comment.
With this change we are altering the corresponding interface, which means we should also increase its version in both RAML and ModuleDescriptor
|
|
||
| JsonObject loan = loansClient.create(loanRequest).getJson(); | ||
|
|
||
| assertThat("id does not match", |
There was a problem hiding this comment.
Do we really have to check every property of the loan in these test cases? We are only adding one, so maybe checking that this new field can be read and written is enough?
|
Vignesh-kalyanasundaram
approved these changes
Jun 6, 2024
gurleenkaurbp
approved these changes
Jun 6, 2024
OleksandrVidinieiev
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose: https://folio-org.atlassian.net/browse/CIRCSTORE-506
Approach: added isDcb flag in loan.json and added few testcases for loan creation when is isDcb feild is present with values true or false