Skip to content

Commit

Permalink
Upgrades to RAML Module Builder 30.2.4 CIRCSTORE-220
Browse files Browse the repository at this point in the history
Updating RMB from 30.0.1 to RMB 30.2.4 fixes
https://issues.folio.org/browse/CIRCSTORE-210 "Requests -Filtering
by Request Type returns (Total Records = 1000) when there are more"
because it includes these fixes:

* [RMB-637](https://issues.folio.org/browse/RMB-637) Run ANALYZE after index (re-)creation
* [RMB-645](https://issues.folio.org/browse/RMB-645) Use where-only clause for the "count query"
* [RMB-639](https://issues.folio.org/browse/RMB-639) Unexpected breaking changes streamGet and getWithOptimizedSql

https://github.com/folio-org/raml-module-builder/blob/master/doc/upgrading.md#version-302 advises:
> https://issues.folio.org/browse/RMB-652 error message "may not be null" changed to "must not be null" (hibernate-validator)
  • Loading branch information
julianladisch authored and marcjohnson-kint committed Jul 15, 2020
1 parent f13308d commit 00f629e
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 6 deletions.
7 changes: 5 additions & 2 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,11 @@
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
<ramlfiles_path>${basedir}/ramls</ramlfiles_path>
<raml-module-builder-version>30.0.1</raml-module-builder-version>
<vertx-version>3.9.0</vertx-version>
<raml-module-builder-version>30.2.4</raml-module-builder-version>
<vertx-version>3.9.1</vertx-version>
<lombok.version>1.18.12</lombok.version>
<spring.version>5.2.7.RELEASE</spring.version>
<rest-assured.version>3.3.0</rest-assured.version>
<argLine />
</properties>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ public void cannotCreateCheckInIfRequiredPropertyMissing() throws InterruptedExc

JsonResponse createResponse = checkInClient.attemptCreate(checkInToCreate);

assertThat(createResponse, isValidationResponseWhich(hasMessage("may not be null")));
assertThat(createResponse, isValidationResponseWhich(hasMessage("must not be null")));
assertThat(createResponse, isValidationResponseWhich(hasParameter("occurredDateTime", "null")));
assertThat(checkInClient.attemptGetById(recordId).getStatusCode(), is(404));
}
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/org/folio/rest/api/LoansApiTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -446,7 +446,7 @@ public void cannotCreateALoanWithoutAction()
JsonResponse response = loansClient.attemptCreate(loanRequest);

assertThat(response, isValidationResponseWhich(allOf(
anyOf(hasMessage("may not be null"), hasMessage("darf nicht null sein")), // any server language
anyOf(hasMessage("must not be null"), hasMessage("darf nicht null sein")), // any server language
hasParameter("action", "null"))));
}

Expand Down
4 changes: 2 additions & 2 deletions src/test/java/org/folio/rest/api/RequestPoliciesApiTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ public void cannotCreateRequestPolicyWithoutName()
assertThat(response2, isUnprocessableEntity());
JsonObject error = extractErrorObject(response2);
assertThat("unexpected error message", error,
anyOf(hasMessage("may not be null"), hasMessage("darf nicht null sein"))); // any server language
anyOf(hasMessage("must not be null"), hasMessage("darf nicht null sein"))); // any server language
}

@Test
Expand Down Expand Up @@ -574,7 +574,7 @@ public void cannotUpdateRequestPolicyWithoutName()

JsonObject error = extractErrorObject(response2);
assertThat("unexpected error message", error,
anyOf(hasMessage("may not be null"), hasMessage("darf nicht null sein"))); // any server language
anyOf(hasMessage("must not be null"), hasMessage("darf nicht null sein"))); // any server language
}

@Test
Expand Down

0 comments on commit 00f629e

Please sign in to comment.