Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MODUAD-199 - pubsub permission changes. #177

Merged
merged 7 commits into from
Nov 18, 2024
Merged

MODUAD-199 - pubsub permission changes. #177

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8a34ab8
pubsub permission changes.
gurleenkaurbp Nov 5, 2024
f82f2a0
pubsub permission changes.
gurleenkaurbp Nov 5, 2024
5f51e8b
Changes related to audit.pub-sub-handlers.log-record-event.post
TarasSpashchenko Nov 5, 2024
4b05c7b
pubsub permission changes.
gurleenkaurbp Nov 5, 2024
b0cb1f5
pubsub permission changes.
gurleenkaurbp Nov 7, 2024
7829688
Merge branch 'master' into test-pubsub-permission
gurleenkaurbp Nov 7, 2024
bbc4c4d
Merge branch 'master' into test-pubsub-permission
gurleenkaurbp Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions descriptors/ModuleDescriptor-template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,17 +188,15 @@
{
"methods": ["POST"],
"pathPattern": "/audit/handlers/log-record",
"permissionsRequired": [
"pubsub.events.post"
],
julianladisch marked this conversation as resolved.
Show resolved Hide resolved
"modulePermissions": [
"users.item.get",
"users.collection.get",
"templates.item.get",
"inventory.items.item.get",
"inventory-storage.holdings.item.get",
"circulation-storage.cancellation-reasons.collection.get",
"circulation-item.item.get"
"circulation-item.item.get",
"audit.pub-sub-handlers.log-record-event.post"
]
}
]
Expand Down
14 changes: 14 additions & 0 deletions pom.xml
View file
Open in desktop
Copy link
Contributor

@julianladisch julianladisch Nov 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We either

  • need a new validator version that allows "audit.pub-sub-handlers.log-record-event.post" to be defined in mod-pubsub.
  • or, if we don't want to wait for the new version, need to disable the execution of this old version of the validator.

Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
<main.basedir>${project.basedir}</main.basedir>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
<folio-module-descriptor-validator.version>1.0.0</folio-module-descriptor-validator.version>
<argLine />
</properties>

Expand Down Expand Up @@ -182,6 +183,19 @@
</dependency>
</dependencies>
</plugin>
<plugin>
<groupId>org.folio</groupId>
<artifactId>folio-module-descriptor-validator</artifactId>
<version>${folio-module-descriptor-validator.version}</version>
<inherited>false</inherited>
<executions>
<execution>
<goals>
<goal>validate</goal>
</goals>
</execution>
</executions>
</plugin>
</plugins>
</build>

Expand Down