Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MODAUD-177 Added the virtual item lookup if item is missed in Inventory #157

Merged
merged 5 commits into from
Dec 15, 2023

Conversation

Vignesh-kalyanasundaram
Copy link
Contributor

@Vignesh-kalyanasundaram Vignesh-kalyanasundaram commented Dec 14, 2023

Purpose

The purpose of the jira is to implement MODAUD-177

Approach

If the log records is posted for a virtual item with action fee/fine , then InstanceId and holdingsId is not returned whenever they are retrieved in Circ log. Since the virtual item is not present in the inventory, it returns 404 and the subsequent call to holdings storage and instance storage is not happening. In order to fix this, whenever the itemObject is null, we will look into the circulation-item module to retrieve its data.

Evidence
Mod-audit1

TODOS and Open Questions

Learning

Pre-Merge Checklist:

Before merging this PR, please go through the following list and take appropriate actions.

  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • Were any API paths or methods changed, added or removed?
    • Were there any schema changes?
    • Did any of the interface versions change?
    • Were permissions changed, added, or removed?
    • Are there new interface dependencies?
    • There are no breaking changes in this PR.
    • Check logging

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

Copy link

@Vignesh-kalyanasundaram Vignesh-kalyanasundaram changed the title UICIRCLOG-149 Added the virtual item lookup if item is missed in Inventory MODAUD-177 Added the virtual item lookup if item is missed in Inventory Dec 14, 2023
@Vignesh-kalyanasundaram Vignesh-kalyanasundaram requested a review from a team December 14, 2023 13:40
@Vignesh-kalyanasundaram Vignesh-kalyanasundaram merged commit 3db06ef into master Dec 15, 2023
6 checks passed
gurleenkaurbp pushed a commit that referenced this pull request Dec 15, 2023
…ory (#157)

* UICIRCLOG-149 Make a call to circulation-item module if the item is not present

* UICIRCLOG-149 Adding permission

* UICIRCLOG-149 Adding new module in module descriptor

* UICIRCLOG-149 Adding test cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants