MODAUD-183 - fixing the failed test cases.

folio-org · Mar 9, 2024 · f2a3041 · f2a3041
1 parent d74a146
commit f2a3041
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/mod-audit-server/src/main/java/org/folio/rest/impl/AuditHandlersService.java b/mod-audit-server/src/main/java/org/folio/rest/impl/AuditHandlersService.java
@@ -44,14 +44,15 @@ public void postAuditHandlersLogRecord(String entity, Map<String, String> okapiH
         .exceptionally(throwable -> {
           LOGGER.warn("Error saving log event : {} due to : {}", entity, throwable.getLocalizedMessage());
           return null;
-        }).thenAccept(v ->
-          asyncResultHandler.handle(succeededFuture(PostAuditHandlersLogRecordResponse.respond204()))
-        );
+        });
     } catch (Exception e) {
       LOGGER.warn("Error saving log event for entity {} due to {} ", entity, e.getMessage());
+    } finally {
       asyncResultHandler.handle(succeededFuture(PostAuditHandlersLogRecordResponse.respond204()));
     }
   }
+
+
   private CompletableFuture<List<LogRecord>> processAnonymize(List<LogRecord> records,
     Map<String, String> okapiHeaders, Context vertxContext) {
     LOGGER.debug("processAnonymize:: Processing anonymize for records");

diff --git a/mod-audit-server/src/test/java/org/folio/rest/impl/CirculationLogsImplApiTest.java b/mod-audit-server/src/test/java/org/folio/rest/impl/CirculationLogsImplApiTest.java
@@ -95,7 +95,7 @@ void anonymizeLoanShouldRemoveUserDataFromRelatedRecords() {
       .log().all()
       .statusCode(204);
 
-    await().atLeast(1, TimeUnit.SECONDS);
+    await().pollDelay(1, TimeUnit.SECONDS).until(() -> true);
 
     given().headers(HEADERS).get(CIRCULATION_LOGS_ENDPOINT + "?query=(items=845687423)")
       .then().log().all().statusCode(200)