Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Eslint #21

Merged
merged 6 commits into from
May 18, 2023
Merged

feat: Add Eslint #21

merged 6 commits into from
May 18, 2023

Conversation

karannakra
Copy link
Contributor

@karannakra karannakra commented May 15, 2023

Ticket Link Issue-10

🏆 PR Goals 🏆

  • Add Eslint
  • Add Eslint Configurations
  • Fix all errors or warnings that came across after adding eslint
  • Sort imports warning should be fixable when --fix flag is passed

🗒️ TODO 🗒️

  • Make sure to turn on all the rules that are required and has been turned off in this PR

@vercel
Copy link

vercel bot commented May 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
b2b-saaskit ✅ Ready (Inspect) Visit Preview May 18, 2023 4:17am

@JLarky
Copy link
Contributor

JLarky commented May 18, 2023

Check the settings of original repo, especially:

  • jsonc
  • jsx-a11y

@JLarky JLarky force-pushed the feat--add-eslint branch from 21b78b4 to f2f4e4c Compare May 18, 2023 04:17
@JLarky JLarky merged commit abee533 into main May 18, 2023
@JLarky JLarky deleted the feat--add-eslint branch May 18, 2023 04:18
@karannakra
Copy link
Contributor Author

Check the settings of original repo, especially:

  • jsonc
  • jsx-a11y

Acknowledged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants