Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Matomo Tag Manager Support #51

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

amenk
Copy link

@amenk amenk commented Apr 29, 2021

No description provided.

amenk added 4 commits April 29, 2021 21:48
* Add config flag for switching between Tag Manager Container and direct Tracking code
* Don't check for window._mtm anymore -> use configuration
* Remote unnecessary JsOptions / calls only for paq
* Separate templates
* Include the Tag Manager code in the <head> tag
Comment on lines +24 to +27
return;
}
?>
<script type="text/x-magento-init">
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the original PR (that targeted the fork), @amenk wrote:

I am wondering if we could extract this, together with the workaround script, to a seperate template to avoid duplication

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you think? should we create an additional block (actually 2 additional blocks) or leave it like that?

@amenk
Copy link
Author

amenk commented May 3, 2021

@fnogatz Can you re-trigger travis :D ?

@amenk
Copy link
Author

amenk commented May 6, 2021

Thanks for merging the latest main branch.
The build seems to fail due to private CI variables not being available in PR builds?

@fnogatz
Copy link
Owner

fnogatz commented May 7, 2021

Exactly 😞 Any idea how to solve this? According to the Travis CI documentation, apparently, there's no way to specify private environment variables in a way that's available for PRs coming from forks. I don't think it's a good idea to have just some credentials for the Magento repo in the composer config (as suggested in #52), as they might be copied by other projects etc. You don't want to have credentials in your .travis.yml at all.

@amenk
Copy link
Author

amenk commented May 7, 2021

There is this https://fooman.com/blog/no-authentication-needed-magento-2-mirror.html

fnogatz added a commit that referenced this pull request May 11, 2021
* Use Fooman-mirror for Travis installation to avoid requiring credentials (see https://fooman.com/blog/no-authentication-needed-magento-2-mirror.html and #51)

* Use --add-repository CLI flag to stick to fooman mirror

* Stick to https://repo-magento-mirror.fooman.co.nz/ mirror on installation

* Downgrade to composer v1 in Travis job matrix

* Downgrade to composer v1 in Travis job matrix

* Install dev-dependencies in 2nd step

* Work around memory limit

* Set composer version in environment variable

* Use latest versions of 2.3.3, 2.3.4, and 2.3.5

* Remove pre-2.3.6 Magento versions from Travis CI matrix
@hubertus2017
Copy link

Hello,
thank you for maintaining this plugin.

Can perhaps a forecast be made as to when tag manager support for magento will be released?

@amenk
Copy link
Author

amenk commented Nov 23, 2022

Hm how shall we proceed on that? The checks are now successful.
Can it be merged?

@drabikowy
Copy link

Hello! Is there a chance this will be merged soon?
Also, am I reading this code correctly, that using Matomo Tag Manager will mean that we can't use direct tracking?
Is it possible to have both? Direct tracing for Matomo Analytics and Tag Manager for managing tags only?

@amenk
Copy link
Author

amenk commented Mar 29, 2023

Yes, @drabikowy - if I remember it correctly the configuration switch replaces the direct Matomo tracking with tag manager. It was implemented that way because we add Matomo tracking in the tag manager. The variables can be passed through, so it should be pretty straight forward easy to set this up.

If you have a use case to support both, feel free to provide a modified pull request.

@amenk
Copy link
Author

amenk commented Sep 20, 2023

poke can this eventually be merged and released ?

@psg-webdev
Copy link

Please merge this important & essential feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants