-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New FsGrid operators and lerp method #21
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty nice! Also, this is a wonderful step in the direction of a fully vectorized fieldsolver implmentation (although I dread the day that anyone of us would have to reformulate the hall component expressions into a new syntax).
Are there any simple parts of the fieldsolver where this could be directly taken into use, just to compare the performance?
Appears to run, and the interpolation at least doesn't break testpackage runs completely :) |
@markusbattarbee Right Markus I forgot to push the changes to that so it does not even compile now. Will be fixed in the next push that has a few more operators coming |
-This PR implements new operators for FsGrid .
-Now one can use
+, -,+=,-=,*,*=,/,/=
with FsGrid data structures.-There is also a new
lerp_t
method which linearly interpolates between two existing FsGrids. It can be used like this:-This PR also updates the tests so handles #20 and that can be closed if you want.
where
A,B
are FsGrids of same signaturet_a,t_b
are timestamps that corespond to A and Bres
I have implemented a few ways to make it more safe. For example we do not want to add a string to a perB field I guess :D
I also have a new test
test/operators.cpp
that demos some of the added functionality.I will be doing more tests to catch any bugs or edge cases. So this is WIP.
Let me know what you think and what I should change :)