fix string comparison

fmessmer · Sep 15, 2018 · 4854154 · 4854154
1 parent d5a7eaa
commit 4854154
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/main/java/com/github/rosjava_actionlib/ActionClient.java b/src/main/java/com/github/rosjava_actionlib/ActionClient.java
@@ -108,7 +108,7 @@ public void detachListener(ActionClientListener target) {
      */
     public ActionFuture<T_ACTION_GOAL, T_ACTION_FEEDBACK, T_ACTION_RESULT> sendGoal(T_ACTION_GOAL agMessage, String id) {
         GoalID gid = getGoalId(agMessage);
-        if (id == "") {
+        if (id.equals("")) {
             goalIdGenerator.generateID(gid);
         } else {
             gid.setId(id);

diff --git a/src/main/java/com/github/rosjava_actionlib/ActionGoal.java b/src/main/java/com/github/rosjava_actionlib/ActionGoal.java
@@ -254,6 +254,6 @@ public void setGoalMessage(Message gm) {
     }
 
     public boolean equalId(ActionGoal ag) {
-        return (this.getGoalId() == ag.getGoalId());
+        return (this.getGoalId().equals(ag.getGoalId()));
     }
 }