Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add motherduck examples for duckdb plugin #1730

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

dansola
Copy link
Contributor

@dansola dansola commented Sep 10, 2024

Recently the duckdb plugin was updated here: flyteorg/flytekit#2680

This PR updates the flyte docs.

@samhita-alla
Copy link
Contributor

@dansola can you take a look at the failed checks?

Signed-off-by: Daniel Sola <[email protected]>
@dansola
Copy link
Contributor Author

dansola commented Sep 11, 2024

@dansola can you take a look at the failed checks?

good call. I think there was a failing lint test (which I fixed) and also an import error for DuckDBProvider in the duckdb test. I think this must be because we haven't cut a release with the newest version. are we able to do quick releases for plugins or does it have to follow main flytekit releases?

Also now it looks like all test fail because of a github actions deprecation.

Signed-off-by: Daniel Sola <[email protected]>
@samhita-alla
Copy link
Contributor

@dansola how about you add the flytekit beta version whichever has the updated plugin to duckdb requirements?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants