Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Sync Plugin Interface #409

Closed

Conversation

Future-Outlier
Copy link
Member

TL;DR

As title.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

I need maintainers to take a look at whether this implementation is good enough.
Currently, the "core. go" file is not fully completed, but you can take a look at the interface.

Tracking Issue

flyteorg/flyteidl#436
flyteorg/flytekit#1822

Follow-up issue

flyteorg/flyte#3936

Future Outlier added 2 commits September 27, 2023 21:42
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
@eapolinario
Copy link
Contributor

eapolinario commented Oct 3, 2023

Hi, we are moving all Flyte development to a monorepo. In order to help the transition period, we're moving open PRs to monorepo automatically and your PR was moved to . Notice that if there are any conflicts in the resulting PR they most likely happen due to the change in the import path of the flyte components.

edit: Re-opening these PRs as the automation failed.

@eapolinario eapolinario closed this Oct 3, 2023
@eapolinario eapolinario reopened this Oct 3, 2023
@Future-Outlier
Copy link
Member Author

@eapolinario I have moved the PR to here.
flyteorg/flyte#4107

@eapolinario
Copy link
Contributor

Hi, we are moving all Flyte development to a monorepo. In order to help the transition period, we're moving open PRs to monorepo automatically and your PR was moved to flyteorg/flyte#4131. Notice that if there are any conflicts in the resulting PR they most likely happen due to the change in the import path of the flyte components.

@eapolinario eapolinario closed this Oct 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants