Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Override RayJob configs #380

Closed
wants to merge 1 commit into from
Closed

Override RayJob configs #380

wants to merge 1 commit into from

Conversation

pingsutw
Copy link
Member

TL;DR

wip

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue

fixes https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

Signed-off-by: Kevin Su <[email protected]>
@pingsutw pingsutw marked this pull request as draft July 26, 2023 18:29
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Attention: 116 lines in your changes are missing coverage. Please review.

Comparison is base (3405f89) 63.00% compared to head (591d066) 64.20%.
Report is 19 commits behind head on master.

❗ Current head 591d066 differs from pull request most recent head 6c9f374. Consider uploading reports for the commit 6c9f374 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #380      +/-   ##
==========================================
+ Coverage   63.00%   64.20%   +1.20%     
==========================================
  Files         154      156       +2     
  Lines       13030    10707    -2323     
==========================================
- Hits         8209     6874    -1335     
+ Misses       4208     3202    -1006     
- Partials      613      631      +18     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
go/tasks/pluginmachinery/core/phase.go 21.50% <ø> (-1.27%) ⬇️
go/tasks/pluginmachinery/flytek8s/config/config.go 50.00% <ø> (ø)
...machinery/flytek8s/config/k8spluginconfig_flags.go 51.28% <100.00%> (+3.78%) ⬆️
go/tasks/pluginmachinery/flytek8s/pod_helper.go 71.07% <100.00%> (-3.03%) ⬇️
go/tasks/pluginmachinery/internal/webapi/cache.go 85.71% <100.00%> (+5.91%) ⬆️
go/tasks/pluginmachinery/internal/webapi/state.go 100.00% <ø> (ø)
go/tasks/plugins/array/k8s/subtask_exec_context.go 83.18% <100.00%> (+1.36%) ⬆️
go/tasks/plugins/hive/execution_state.go 71.92% <100.00%> (+1.51%) ⬆️
go/tasks/plugins/k8s/ray/config_flags.go 38.70% <100.00%> (+2.34%) ⬆️
go/tasks/plugins/webapi/agent/config.go 100.00% <ø> (ø)
... and 17 more

... and 114 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hamersaw
Copy link
Contributor

@eapolinario
Copy link
Contributor

eapolinario commented Oct 3, 2023

Hi, we are moving all Flyte development to a monorepo. In order to help the transition period, we're moving open PRs to monorepo automatically and your PR was moved to . Notice that if there are any conflicts in the resulting PR they most likely happen due to the change in the import path of the flyte components.

edit: Re-opening these PRs as the automation failed.

@eapolinario eapolinario closed this Oct 3, 2023
@eapolinario eapolinario reopened this Oct 3, 2023
@eapolinario
Copy link
Contributor

Hi, we are moving all Flyte development to a monorepo. In order to help the transition period, we're moving open PRs to monorepo automatically and your PR was moved to flyteorg/flyte#4137. Notice that if there are any conflicts in the resulting PR they most likely happen due to the change in the import path of the flyte components.

@eapolinario eapolinario closed this Oct 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants