Tracks progress for package creation, upload and kickoff #2935
Conversation
Signed-off-by: Ketan Umare <[email protected]>
kumare3
requested review from
wild-endeavor,
eapolinario,
pingsutw,
cosmicBboy,
samhita-alla,
thomasjpfan and
Future-Outlier
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2935 +/- ##
===========================================
+ Coverage 76.33% 93.26% +16.93%
===========================================
Files 199 48 -151
Lines 20840 1842 -18998
Branches 2681 0 -2681
===========================================
- Hits 15908 1718 -14190
+ Misses 4214 124 -4090
+ Partials 718 0 -718 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
I think we could consider implementing a global Progress to:
- Simplify the codebase
- Enable consistent progress reporting behavior across modules
- Make it easier to add progress tracking to new modules
- Allow for a global flag to enable/disable all progress logging (especially if we want something like
--verboseor--silence)
| f"Request to send data {upload_location.signed_url} failed.\nResponse: {rsp.text}", | ||
| from rich.progress import Progress, TextColumn, TimeElapsedColumn | ||
|
|
||
| progress = Progress( |
There was a problem hiding this comment.
Progress also has a start method, which is supposed to be invoked explicitly if the Progress object is not used as a context manager (as mentioned by the author here).
We can use this to make the progress bar customizable.
There was a problem hiding this comment.
@eapolinario progress is used as a context manager. look at like 1074
There was a problem hiding this comment.
Yeah, I understand, but it doesn't have to be used as a context manager, right? If start is not called the progress bars don't show up.
Signed-off-by: Ketan Umare <[email protected]>
Allows users to understand through visualization if large packages are being uploaded or incorrect files are being packaged.