-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds experimental support for uv.lock in ImageSpec #2929
base: master
Are you sure you want to change the base?
Adds experimental support for uv.lock in ImageSpec #2929
Conversation
Signed-off-by: Thomas J. Fan <[email protected]>
Signed-off-by: Thomas J. Fan <[email protected]>
Signed-off-by: Thomas J. Fan <[email protected]>
Signed-off-by: Thomas J. Fan <[email protected]>
…rt_uv_lock Signed-off-by: Thomas J. Fan <[email protected]>
Signed-off-by: Thomas J. Fan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wish we had a better way to signal that uv lock files could be used in imagespec that didn't involve overloading the requirements
parameter. Can't think of anything better though, so let's get this out.
|
||
requirements = [] | ||
if image_spec.packages is not None: | ||
msg = "uv.lock is not compatible with packages, please include all your dependencies in uv.lock" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: should this mention that support for uv.lock
files and packages is mutually exclusive instead?
Signed-off-by: Thomas J. Fan <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2929 +/- ##
===========================================
- Coverage 94.25% 79.36% -14.90%
===========================================
Files 18 199 +181
Lines 1358 20910 +19552
Branches 0 2691 +2691
===========================================
+ Hits 1280 16595 +15315
- Misses 78 3574 +3496
- Partials 0 741 +741 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
…rt_uv_lock Signed-off-by: Thomas J. Fan <[email protected]>
Can you merge master to fix the errors in CI? |
Why are the changes needed?
uv and
uv.lock
is becoming a commonly used tool for managing python environments. This PR adds experimental support foruv.lock
intoImageSpec
.What changes were proposed in this pull request?
This PR enables
requirements="uv.lock"
support inImageSpec
. Usinguv.lock
shows a warning stating thatuv.lock
support is experimental sinceuv sync
is experimental, so our integration may change.How was this patch tested?
where
main.py
is: