Async Agent Interface Refactor #2467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Interface Signed-off-by: Future-Outlier <[email protected]>
Future-Outlier
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw,
cosmicBboy and
samhita-alla
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2467 +/- ##
==========================================
+ Coverage 50.73% 51.00% +0.27%
==========================================
Files 182 185 +3
Lines 18477 18619 +142
Branches 3628 3628
==========================================
+ Hits 9374 9497 +123
- Misses 8625 8644 +19
Partials 478 478 ☔ View full report in Codecov by Sentry. |
…position Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
pingsutw
approved these changes
Jun 7, 2024
bgedik
pushed a commit
to bgedik/flytekit
that referenced
this pull request
Jul 3, 2024
Signed-off-by: bugra.gedik <[email protected]>
fiedlerNr9
pushed a commit
that referenced
this pull request
Jul 25, 2024
Signed-off-by: Jan Fiedler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
flyteorg/flyte#3936
Why are the changes needed?
As this PR mentioned,
we should make
SyncAgentBaseandAsyncAgentBasehave the same interfacehttps://github.com/flyteorg/flytekit/blob/master/flytekit/extend/backend/base_agent.py#L123