Add security context to task execution metadata #2296
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahjax
force-pushed
the
noahjax.add-security-context-to-metadata
branch
2 times, most recently
from
0075cf9
to
2dc44d3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2296 +/- ##
==========================================
- Coverage 83.50% 82.33% -1.18%
==========================================
Files 324 324
Lines 24672 24677 +5
Branches 3512 3513 +1
==========================================
- Hits 20603 20318 -285
- Misses 3438 3721 +283
- Partials 631 638 +7 ☔ View full report in Codecov by Sentry. |
noahjax
force-pushed
the
noahjax.add-security-context-to-metadata
branch
from
2dc44d3
to
ab29e87
Compare
noahjax
changed the title
noahjax
force-pushed
the
noahjax.add-security-context-to-metadata
branch
from
ab29e87
to
2e02777
Compare
Signed-off-by: noahjax <[email protected]>
noahjax
force-pushed
the
noahjax.add-security-context-to-metadata
branch
from
2e02777
to
72c1903
Compare
|
Closed in favor of #2315 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
https://github.com/flyteorg/flyte/issues/
Why are the changes needed?
For our specific use case it is critical to be able to determine the identity for the subject who launches a task. It seems like other information on the security context could also be more generally useful, so I included that in addition to the critical execution_identity field as part of this PR.
What changes were proposed in this pull request?
Add securityContext to TaskExecutionMetadata. This builds on top of conjunction with #2282, and relies on flyteorg/flyte#5105 to add security context to the flyteidl TaskExecutionMetadata.
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link