Fixed CI job error (aiohttp) #2007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Future Outlier <[email protected]>
Future-Outlier
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw and
cosmicBboy
as code owners
added 2 commits
November 29, 2023 16:24
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
Future-Outlier
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2007 +/- ##
==========================================
+ Coverage 86.03% 86.11% +0.08%
==========================================
Files 303 315 +12
Lines 22589 23197 +608
Branches 3456 3456
==========================================
+ Hits 19434 19977 +543
- Misses 2565 2629 +64
- Partials 590 591 +1 ☔ View full report in Codecov by Sentry. |
added 2 commits
November 29, 2023 21:55
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
pingsutw
approved these changes
Nov 29, 2023
6 tasks
RRap0so
pushed a commit
to RRap0so/flytekit
that referenced
this pull request
Dec 15, 2023
* fixed Signed-off-by: Future Outlier <[email protected]> * fixed by downgrade version Signed-off-by: Future Outlier <[email protected]> * add aioresponses back Signed-off-by: Future Outlier <[email protected]> * aio fixed Signed-off-by: Future Outlier <[email protected]> * update req Signed-off-by: Future Outlier <[email protected]> --------- Signed-off-by: Future Outlier <[email protected]> Co-authored-by: Future Outlier <[email protected]> Signed-off-by: Rafael Raposo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Let's downgrade the version of it first.
When
aioresponserelease new packages, we can update bothaiohttpandaioresponsespackages.aioresponsesPR: pnuckowski/aioresponses#248