Add bom module #247
Add bom module #247
Conversation
| <modelVersion>4.0.0</modelVersion> | ||
|
|
||
| <groupId>org.flyte</groupId> | ||
| <artifactId>flytekit-bom</artifactId> |
There was a problem hiding this comment.
Note that we should not use parent for a bom module because that will result in leaking dependencies that are declared in the parent dependencyManagement section.
| @@ -33,7 +33,6 @@ | |||
| <scala.baseVersion>2.13</scala.baseVersion> | |||
| <scala.version>2.13.10</scala.version> | |||
|
|
|||
| <maven.deploy.skip>true</maven.deploy.skip> | |||
There was a problem hiding this comment.
This property doesn't make much sense because we do not use mvn deploy to publish artifacts.
There was a problem hiding this comment.
Also this property is not set consistently across the entire code code. For example integration-tests module should have had it.
flytekit-bom/pom.xml
Outdated
| @@ -0,0 +1,155 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <!-- | |||
| Copyright 2021 Flyte Authors. | |||
|
Hmm, this seems to break spotless because the plugin is not defined in bom. |
| </dependencyManagement> | ||
|
|
||
| <build> | ||
| <pluginManagement> |
There was a problem hiding this comment.
Sadly we need to configure this again because bom has no parent so it cannot inherit.
|
Converted to draft because there is still something missing. |
Signed-off-by: Hongxin Liang <[email protected]>
Signed-off-by: Hongxin Liang <[email protected]>
Signed-off-by: Hongxin Liang <[email protected]>
Signed-off-by: Hongxin Liang <[email protected]>
Signed-off-by: Hongxin Liang <[email protected]>
TL;DR
Add bom module for easier module management at user side.
Type
Are all requirements met?
Complete description
flytekit-java has lots of modules, and it is getting complicated for users to manage those. Adding a bom will simplify that.
Tracking Issue
NA
Follow-up issue
NA