Fix testutils.TearDownAndVerify #none

[kamaleybov]

TL;DR

testutils.TearDownAndVerify is being used by several tests to verify that standard output contains certain strings. Currently, it always fails to read from the incorrect stream, and swallows the error. It never fails.

The fix uncovered two failing tests, which this PR also fixes.

Type

• Bug Fix
• Feature
• Plugin

Are all requirements met?

• Code completed
• Smoke tested
• Unit tests added
• Code documentation added
• Any pending items have an associated Issue

Complete description

testutils.TearDownAndVerify:

• close the writer and read from the reader to actually verify correctness of the output in tests
• stop swallowing errors

Tracking Issue

None.

Follow-up issue

NA

[codecov]

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (be75a9e) 66.86% compared to head (027e0c7) 67.63%.

❗ Current head 027e0c7 differs from pull request most recent head ed4f17f. Consider uploading reports for the commit ed4f17f to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #424      +/-   ##
==========================================
+ Coverage   66.86%   67.63%   +0.77%     
==========================================
  Files         145      145              
  Lines        6271     5234    -1037     
==========================================
- Hits         4193     3540     -653     
+ Misses       1796     1412     -384     
  Partials      282      282              

Flag	Coverage Δ
unittests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 134 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.