This repository has been archived by the owner on May 31, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 83
Flyte Add Enable/Disable Options for Agent Services #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
Future-Outlier
requested review from
kumare3,
EngHabu and
wild-endeavor
as code owners
September 16, 2023 13:22
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
Future-Outlier
changed the title
Add Enable Agent Flag in FlyteCTL
Enable Agent Flag in Command Line
Sep 17, 2023
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
3 tasks
Signed-off-by: Future Outlier <[email protected]>
Future-Outlier
changed the title
Enable Agent Flag in Command Line
Flyte Add Enable/Disable Options for Agent Services
Oct 7, 2023
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #420 +/- ##
==========================================
+ Coverage 66.86% 67.69% +0.82%
==========================================
Files 145 145
Lines 6271 5237 -1034
==========================================
- Hits 4193 3545 -648
+ Misses 1796 1411 -385
+ Partials 282 281 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
pingsutw
reviewed
Oct 8, 2023
Co-authored-by: Kevin Su <[email protected]> Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
pingsutw
approved these changes
Oct 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
--disable-agent
Type
Are all requirements met?
Complete description
@pingsutw and I have introduced two options for users to configure the Flyte agent - it can now be either enabled or disabled.
We believe this enhancement will offer more flexibility and cater to diverse user needs and deployment scenarios.
After a thorough consideration, we have decided to set the "enable agent" option as the default setting.
Enable agent service (Default)
Enable the agent deployment by updating helm and kustomization.
You can use my image on the docker hub to test.
Disable agent service (Use flag)
Tracking Issue
flyteorg/flyte#3936
flyteorg/flyte#4041