Skip to content
This repository has been archived by the owner on May 31, 2024. It is now read-only.

Flyte Add Enable/Disable Options for Agent Services #420

Merged
merged 10 commits into from
Oct 17, 2023

Conversation

Future-Outlier
Copy link
Member

@Future-Outlier Future-Outlier commented Sep 16, 2023

TL;DR

  • Added options to enable (default) or disable the Flyte agent.
  • Add a flag --disable-agent

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

@pingsutw and I have introduced two options for users to configure the Flyte agent - it can now be either enabled or disabled.

We believe this enhancement will offer more flexibility and cater to diverse user needs and deployment scenarios.

After a thorough consideration, we have decided to set the "enable agent" option as the default setting.

Enable agent service (Default)

Enable the agent deployment by updating helm and kustomization.
You can use my image on the docker hub to test.

cd flyte/docker/sandbox-bundled/
make build
docker tag flyte-sandbox:latest futureoutlier/flyte-sandbox:flyteagent-v2
docker push futureoutlier/flyte-sandbox:flyteagent-v2
./bin/flytectl demo start --image futureoutlier/flyte-sandbox:flyteagent-v2

Disable agent service (Use flag)

./bin/flytectl demo start --image futureoutlier/flyte-sandbox:flyteagent-v2 --disable-agent

Tracking Issue

flyteorg/flyte#3936
flyteorg/flyte#4041

Future Outlier added 2 commits September 16, 2023 17:04
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
Future Outlier added 2 commits September 16, 2023 22:06
Signed-off-by: Future Outlier <[email protected]>
@Future-Outlier Future-Outlier changed the title Add Enable Agent Flag in FlyteCTL Enable Agent Flag in Command Line Sep 17, 2023
Future Outlier added 2 commits September 17, 2023 15:36
Signed-off-by: Future Outlier <[email protected]>
@Future-Outlier Future-Outlier changed the title Enable Agent Flag in Command Line Flyte Add Enable/Disable Options for Agent Services Oct 7, 2023
@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (5fea354) 66.86% compared to head (f1ad72d) 67.69%.
Report is 1 commits behind head on master.

❗ Current head f1ad72d differs from pull request most recent head 561c6e7. Consider uploading reports for the commit 561c6e7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #420      +/-   ##
==========================================
+ Coverage   66.86%   67.69%   +0.82%     
==========================================
  Files         145      145              
  Lines        6271     5237    -1034     
==========================================
- Hits         4193     3545     -648     
+ Misses       1796     1411     -385     
+ Partials      282      281       -1     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cmd/config/subcommand/sandbox/config_flags.go 42.42% <100.00%> (+4.18%) ⬆️
pkg/sandbox/start.go 62.18% <100.00%> (+3.82%) ⬆️

... and 132 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Future-Outlier and others added 2 commits October 8, 2023 20:41
Co-authored-by: Kevin Su <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
nit
Signed-off-by: Future Outlier <[email protected]>
@pingsutw pingsutw merged commit 64e0d7b into flyteorg:master Oct 17, 2023
12 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants