force flag (#431)

Signed-off-by: Future Outlier <[email protected]>
Co-authored-by: Future Outlier <[email protected]>

cmd/config/subcommand/config/init_flags.go

@@ -4,6 +4,7 @@ package config
 var (
 	DefaultConfig = &Config{
 		Insecure: false,
+		Force:    false,
 	}
 )
 
@@ -12,4 +13,5 @@ type Config struct {
 	Console  string `json:"console" pflag:",Endpoint of console, if different than flyte admin"`
 	Host     string `json:"host" pflag:",Endpoint of flyte admin"`
 	Insecure bool   `json:"insecure" pflag:",Enable insecure mode"`
+	Force    bool   `json:"force" pflag:",Force to overwrite the default config file without confirmation"`
 }

cmd/configuration/configuration.go

@@ -70,6 +70,8 @@ func CreateConfigCommand() *cobra.Command {
 			Long:  initCmdLong, PFlagProvider: initConfig.DefaultConfig},
 	}
 
+	configCmd.Flags().BoolVar(&initConfig.DefaultConfig.Force, "force", false, "Force to overwrite the default config file without confirmation")
+
 	cmdcore.AddCommands(configCmd, getResourcesFuncs)
 	return configCmd
 }
@@ -109,7 +111,7 @@ func initFlytectlConfig(reader io.Reader) error {
 	if _, err := os.Stat(configutil.ConfigFile); os.IsNotExist(err) {
 		_err = configutil.SetupConfig(configutil.ConfigFile, templateStr, templateValues)
 	} else {
-		if cmdUtil.AskForConfirmation(fmt.Sprintf("This action will overwrite an existing config file at [%s]. Do you want to continue?", configutil.ConfigFile), reader) {
+		if initConfig.DefaultConfig.Force || cmdUtil.AskForConfirmation(fmt.Sprintf("This action will overwrite an existing config file at [%s]. Do you want to continue?", configutil.ConfigFile), reader) {
 			if err := os.Remove(configutil.ConfigFile); err != nil {
 				return err
 			}

cmd/configuration/configuration_test.go

@@ -41,12 +41,12 @@ func TestCreateInitCommand(t *testing.T) {
 	assert.Equal(t, initCmdShort, cmdNouns[2].Short)
 	assert.Equal(t, "validate", cmdNouns[3].Use)
 	assert.Equal(t, "Validates the loaded config.", cmdNouns[3].Short)
-
 }
 
 func TestSetupConfigFunc(t *testing.T) {
 	var yes = strings.NewReader("Yes")
 	var no = strings.NewReader("No")
+	var empty = strings.NewReader("")
 	mockOutStream := new(io.Writer)
 	ctx := context.Background()
 	_ = os.Remove(configutil.FlytectlConfig)
@@ -59,8 +59,13 @@ func TestSetupConfigFunc(t *testing.T) {
 	initConfig.DefaultConfig.Host = ""
 	assert.Nil(t, err)
 
+	initConfig.DefaultConfig.Force = false
 	assert.Nil(t, initFlytectlConfig(yes))
 	assert.Nil(t, initFlytectlConfig(no))
+
+	initConfig.DefaultConfig.Force = true
+	assert.Nil(t, initFlytectlConfig(empty))
+
 	initConfig.DefaultConfig.Host = "flyte.org"
 	assert.Nil(t, initFlytectlConfig(no))
 	initConfig.DefaultConfig.Host = "localhost:30081"
@@ -86,3 +91,11 @@ func TestValidateEndpointName(t *testing.T) {
 	assert.Equal(t, false, validateEndpointName("112.11.1.1:8080/console"))
 	assert.Equal(t, false, validateEndpointName("flyte"))
 }
+
+func TestForceFlagInCreateConfigCommand(t *testing.T) {
+	cmd := CreateConfigCommand()
+	assert.False(t, initConfig.DefaultConfig.Force)
+	err := cmd.Flags().Parse([]string{"--force"})
+	assert.Nil(t, err)
+	assert.True(t, initConfig.DefaultConfig.Force)
+}